chore(bueno): improve exports, externalize dependencies from bundles #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
louis-bompart
commented
Feb 19, 2025
louis-bompart
commented
- Remove top-level browser export specifier: this was not up to standard; see npm doc
- Add conditional-exports to provide wide compability.
- Externalize dependencies from the bundle:
- It is expected that the final consumers of the package (i.e. those who push the bundles for the browser) do bundles.
- Bundling in dependencies may create duplicate code in final consumer bundles
- Move CDN/browser output outside packaged files (logic follow-up)
louis-bompart
requested review from
erocheleau,
SimonMilord,
mmitiche,
olamothe,
fpbrault,
y-lakhdar and
alexprudhomme
louis-bompart
force-pushed
the
chore/bueno-better-exports
branch
from
b1eb26b to
48f0f09
Compare
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
approved these changes
Feb 19, 2025
| @@ -29,6 +30,7 @@ function nodeEsm() { | |||
| return build({ | |||
| ...base, | |||
| platform: 'node', | |||
| packages: 'external', | |||
There was a problem hiding this comment.
bueno has no dependencies !
| "types": "./dist/definitions/index.d.ts", | ||
| "import": "./dist/bueno.esm.js", | ||
| "require": "./dist/bueno.js", | ||
| "default": "./dist/bueno.js" |
There was a problem hiding this comment.
Should we put ESM as default ?
There was a problem hiding this comment.
I thought about it, but I think it might be breaking
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
louis-bompart
force-pushed
the
chore/bueno-better-exports
branch
from
a421fbb to
73a2e9f
Compare
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.