Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(atomic): fix display-if directive for lit components #4988

Merged
merged 6 commits into from
Feb 20, 2025
Merged

chore(atomic): fix display-if directive for lit components #4988

merged 6 commits into from
Feb 20, 2025

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme marked this pull request as ready for review February 19, 2025 15:25
@alexprudhomme alexprudhomme requested a review from a team as a code owner February 19, 2025 15:25
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.2 244.2 0
commerce 355.5 355.5 0
search 415.5 415.5 0
insight 406.7 406.7 0
recommendation 256.3 256.3 0
ssr 409.3 409.3 0
ssr-commerce 373.2 373.2 0

louis-bompart
louis-bompart approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from KIT-3977 to master February 19, 2025 20:07
@alexprudhomme alexprudhomme requested a review from a team as a code owner February 19, 2025 20:07
@alexprudhomme alexprudhomme removed the request for review from a team February 19, 2025 21:41
@alexprudhomme alexprudhomme added this pull request to the merge queue Feb 20, 2025
Merged via the queue into master with commit d6ef356 Feb 20, 2025
96 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3973 branch February 20, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexprudhomme @y-lakhdar @louis-bompart