CTCORE-10883 remove mentions of dev and stg from our example tool #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTCORE-10883 [Easy File Pusher] Remove mentions of Dev and STG from our example tool
ClaudineL
commented
May 8, 2025
ClaudineL
commented
May 8, 2025
ClaudineL
commented
May 8, 2025
ClaudineL
commented
May 8, 2025
cdroulers-coveo
approved these changes
May 9, 2025
aveilleux
approved these changes
May 9, 2025
ldblanchet
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not so straightforward to do as we thought, since the CI has been broken for years because it uses 'illegal' actions.
I fixed it to the best of my abilities and added NerdBank Gitversioning to handle the versioning. As I understand it, it will increment the build number by 1 for every commit after the commit that last modified the
versionproperty in version.json. So for example, in my branch, it now returns 1.0.1-. If we want to bump the minor or major, we have to do it manually as far as I can tell.I removed the releasing of the binaries since the certificate associated expired back in 2021 and getting a new one is a heap of trouble. The README was updated in consequence, clients can just compile the tool themselves.
I also bumped the version of the PlatformSDK used so it at least matches a recent one. After we've merged this PR, we can approve and merge the PR to setup Renovate that's already open in this repo.
Unfortunately there are more changes than expected because Csharpier got applied, but it's all formatting except the handful of deleted lines.