Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request tokens endpoint #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

crobject
Copy link
Contributor

Endpoint that deals with creating and deleting tokens.

}
}

public static void DrugSearch(Client client)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on combining the drug-related examples into one class, and ditto for form ones? Then perhaps extracting each into their own files so that Program.cs just has the Main class in it?? I haven't done any .NET programming in awhile, but IIRC correctly that's a common practice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a good idea. I was mainly using the CoverMyDotNet.Samples to make sure the client class was working correctly with the api. Ill make those changes though.


namespace CoverMyDotNet.Requests
{
public class SearchForm : RestRequest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that we have one class per API method rather than one per API? Perhaps there is a technical reason imposed by RestSharp, or was this the desired usage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twyfordr RestApi doesn't force you to do that, but I thought that it was the best way to go.

This was referenced Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants