Upgrade to faraday 2 #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
commented
Mar 5, 2024
| # rack 2.x requires ruby 2.2.x | ||
| if RUBY_VERSION < '2.2' | ||
| gem 'rack', '~> 1.6.0', group: :test | ||
| end |
There was a problem hiding this comment.
The minimum was already set to 2.6, this is pointless, removed.
djberg96
commented
Mar 5, 2024
| lib = File.expand_path('../lib', __FILE__) | ||
| $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) | ||
| require 'cover_my_meds/version' | ||
| require_relative 'lib/cover_my_meds/version' |
djberg96
commented
Mar 5, 2024
| spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } | ||
| spec.bindir = "exe" | ||
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | ||
| spec.require_paths = ["lib"] |
There was a problem hiding this comment.
There are no executables, and lib is already the default require path. No idea why the default name was even changed.
djberg96
commented
Mar 5, 2024
| spec.add_development_dependency "webmock", "~> 2.0" | ||
| spec.add_development_dependency "rspec" | ||
| spec.add_development_dependency "rspec-junklet" | ||
| spec.add_development_dependency "webmock" |
There was a problem hiding this comment.
I think we can forego versioning on dev dependencies unless we're really locked into a version.
djberg96
commented
Mar 5, 2024
| spec.add_runtime_dependency "faraday", "~> 2.9.0" | ||
| spec.add_runtime_dependency "faraday-follow_redirects", "~> 0.3.0" | ||
| spec.add_runtime_dependency "faraday-multipart", "~> 1.0.4" | ||
| spec.add_runtime_dependency "faraday-typhoeus", "~> 1.1.0" |
There was a problem hiding this comment.
The extra faraday-xxx dependencies here were required because of the updated faraday gem, i.e. multipart and redirect are no longer baked into it, but require separate gems.
djberg96
commented
Mar 5, 2024
| require 'typhoeus/adapters/faraday' | ||
| require 'faraday/typhoeus' | ||
| require 'faraday/multipart' | ||
| require 'faraday/follow_redirects' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://github.com/lostisland/faraday/blob/main/UPGRADING.md as a guide, update this gem to use faraday 2.x.