Check new VM for IP to ensure it's been assigned before returning #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocks premature restart w/o IP
drewby08
reviewed
Oct 31, 2018
lib/vsphere.rb
Outdated
| wait = wait - poll_interval | ||
| sleep poll_interval | ||
| end | ||
| if wait <= 0 |
There was a problem hiding this comment.
Probably super unlikely but if you are kicked out of this loop once wait == 0 and the new_vm is permuted to get an IP it would be possible to give a false error. Your could instead check if the ip is still nil once you've left this loop if new_vm.guest_ip.nil?. That would also protect you from a nil ip in your else statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks premature restarts w/o IP
This needs to be tested a bit more.