Skip to content

bug: The current conversation cannt be canceled #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

bug: The current conversation cannt be canceled #92

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab0bdeb
fix 4104
smilefisher Apr 24, 2025
08a1b7b
增加条件过滤
smilefisher Apr 24, 2025
78ba367
add Fast fail
smilefisher Apr 24, 2025
39957db
fix fmt error
May 6, 2025
d062d29
1. chat status can not be cancel
Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion chats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,11 @@ func (r *chat) CreateAndPoll(ctx context.Context, req *CreateChatsReq, timeout *
conversationID := chat.ConversationID
now := time.Now()
for {
time.Sleep(time.Second)
if timeout != nil && time.Since(now) > time.Duration(*timeout)*time.Second {
if chat.Status == ChatStatusFailed || chat.Status == ChatStatusCancelled || chat.Status == ChatStatusRequiresAction {
logger.Warnf(ctx, "chat status can not be cancel, conversationID:%v", conversationID)
return nil, errors.New("chat status can not be cancel")
}
logger.Infof(ctx, "Create timeout: ", *timeout, " seconds, cancel Create")
cancelResp, err := r.Cancel(ctx, &CancelChatsReq{
ConversationID: conversationID,
Expand All @@ -50,6 +53,8 @@ func (r *chat) CreateAndPoll(ctx context.Context, req *CreateChatsReq, timeout *
chat = cancelResp.Chat
break
}

time.Sleep(time.Second)
retrieveChat, err := r.Retrieve(ctx, &RetrieveChatsReq{
ConversationID: conversationID,
ChatID: chat.ID,
Expand All @@ -62,6 +67,11 @@ func (r *chat) CreateAndPoll(ctx context.Context, req *CreateChatsReq, timeout *
logger.Infof(ctx, "Create completed, spend: %v", time.Since(now))
break
}
if retrieveChat.Chat.Status == ChatStatusFailed || retrieveChat.Chat.Status == ChatStatusCancelled || retrieveChat.Chat.Status == ChatStatusRequiresAction {
chat = retrieveChat.Chat
logger.Infof(ctx, "Create failed, spend: %v", time.Since(now))
return nil, errors.New(" chat status exist; status: " + string(chat.Status))
}
}
messages, err := r.Messages.List(ctx, &ListChatsMessagesReq{
ConversationID: conversationID,
Expand Down