feat: comments

coze-dev · Dec 3, 2024 · 1fd4cb6 · 1fd4cb6
1 parent 69d92c2
commit 1fd4cb6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/config/rslib-config/index.ts b/config/rslib-config/index.ts
@@ -1,7 +1,7 @@
 import { defineConfig, LibConfig } from '@rslib/core';
 
 type LibFormat = LibConfig['format'];
-export type BundleType = Boolean | 'excludeExternal';
+export type BundleType = boolean | 'excludeExternal';
 
 interface Options {
   format?: LibFormat[];
@@ -21,8 +21,13 @@ function getRslibConfig(options: Options) {
   };
 
   const libs = format.map(libFormat => {
-    const lib = getLibShared(libFormat, bundle!);
+    const lib = getLibShared(libFormat, bundle);
     if (libFormat === 'umd') {
+      if (!umdName) {
+        throw new Error(
+          'getRslibConfig: umdName is required when using UMD format',
+        );
+      }
       lib.umdName = umdName;
       lib.bundle = true;
     }

diff --git a/packages/coze-js/rslib.config.ts b/packages/coze-js/rslib.config.ts
@@ -4,7 +4,6 @@ export default defineConfig(
   getRslibConfig({
     format: ['esm', 'cjs', 'umd'],
     bundle: 'excludeExternal',
-    umdName: 'CozeJs',
     tsconfigPath: './tsconfig.build.json',
   }),
 );