Skip to content

Conversation

HymanShi
Copy link
Collaborator

What type of PR is this?

openapi for evaluation

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@mocayo mocayo changed the title Feat/eval openapi [feat] [evaluate] openapi Sep 24, 2025
service EvaluationOpenAPIService {
// 评测集接口 (9个)
// 1.1 创建评测集
CreateEvaluationSetOpenAPIResponse CreateEvaluationSet(1: CreateEvaluationSetOpenAPIRequest req) (api.post = "/open-apis/evaluation/v1/evaluation_sets")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsy357 也定义了openapi,但是path不太一致,是不是统一下呢, cc @HymanShi

struct GetEvaluationSetOpenAPIRequest {
1: required string workspace_id (api.js_conv="true", go.tag='json:"workspace_id"')
2: required string evaluation_set_id (api.path = "evaluation_set_id")
3: optional bool include_deleted
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个include_deleted为什么要加呢~

2: required string name (vt.min_size = "1", vt.max_size = "255")
3: optional string description (vt.max_size = "2048")
4: optional eval_set.EvaluationSetSchema evaluation_set_schema
5: optional string biz_category (vt.max_size = "128")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个biz_category感觉不需要让用户感知


// 评测集
struct EvaluationSet {
1: optional string evaluation_set_id
Copy link
Collaborator

@dsf86 dsf86 Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么不直接写id呢,还有EvaluationSetVersion里的version_id


// 1.1 创建评测集
struct CreateEvaluationSetOpenAPIRequest {
1: required string workspace_id (api.js_conv="true", go.tag='json:"workspace_id"')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么设置了string呢

dsf86 and others added 12 commits September 28, 2025 14:34
Change-Id: I0efae3f7af582460e46ba629c0f470a10c326025
…ationSet, GetEvaluationSet, ListEvaluationSets

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
… convertor

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…ic to separate methods

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…rate methods

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…unified method parameter

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…error tracking

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…DTO/xxxDTO2DO convention

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
Change-Id: Ibfa77af15a79fc83b6fb5adc44dd132682fe1c05
…rchitecture

(LogID: 20250928231227010091094121028E1E4)

Co-Authored-By: Coda <[email protected]>
Change-Id: I54219f18349d50551302a3129d08ea25f1e15fa1
Change-Id: I4fc1842aea80465df2bfe1d9c7044905b7380cf1
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 0% with 1040 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tion/convertor/evaluation_set/openapi_convertor.go 0.00% 447 Missing ⚠️
...s/evaluation/application/evaluation_openapi_app.go 0.00% 247 Missing ⚠️
...ndler/coze/loop/apis/evaluation_open_apiservice.go 0.00% 176 Missing ⚠️
backend/api/router/coze/loop/apis/middleware.go 0.00% 84 Missing ⚠️
...ackend/api/router/coze/loop/apis/coze.loop.apis.go 0.00% 46 Missing ⚠️
...es/evaluation/infra/metrics/evaluation_set/emit.go 0.00% 30 Missing ⚠️
...nd/modules/evaluation/infra/rpc/foundation/auth.go 0.00% 5 Missing ⚠️
backend/pkg/kitexutil/kitexutil.go 0.00% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   62.76%   61.55%   -1.22%     
==========================================
  Files         479      483       +4     
  Lines       52927    53963    +1036     
==========================================
- Hits        33221    33218       -3     
- Misses      17374    18412    +1038     
- Partials     2332     2333       +1     
Flag Coverage Δ
unittests 61.55% <0.00%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nd/modules/evaluation/infra/rpc/foundation/auth.go 0.00% <0.00%> (ø)
backend/pkg/kitexutil/kitexutil.go 0.00% <0.00%> (ø)
...es/evaluation/infra/metrics/evaluation_set/emit.go 20.00% <0.00%> (-24.00%) ⬇️
...ackend/api/router/coze/loop/apis/coze.loop.apis.go 0.00% <0.00%> (ø)
backend/api/router/coze/loop/apis/middleware.go 2.17% <0.00%> (-0.24%) ⬇️
...ndler/coze/loop/apis/evaluation_open_apiservice.go 0.00% <0.00%> (ø)
...s/evaluation/application/evaluation_openapi_app.go 0.00% <0.00%> (ø)
...tion/convertor/evaluation_set/openapi_convertor.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d027d8b...01f51b5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Change-Id: Ic99ec4e867794d8f6d98c1d4bcad118158bb6969
Change-Id: I7d83bcded9ee778cd4baf63b2682053b88f42b44
Change-Id: Icbeb24eeebd9d6d5d67e1038b0f4acfce9d5759a
Change-Id: I7a78d11c6b3bdd59bb9a08d5cd9daf893c8afa15
Change-Id: I264264a0e8bbf776341fc2149377b7ba934d1c61
Change-Id: Iac21bc6194af354d9c4ad3a0e1a528cccd0f0c4f
Change-Id: I7972ba4c3b4b812652b86187366c2fdd03c7763e
Change-Id: I673a5dc343764edf228ec5d8a8219f0659d8278d
Change-Id: Ie1e50446c90172aea7292f134b117a37a84f0bce
Change-Id: Ia048d5d8836418597fa6ec48c602fbf48e197643
Change-Id: Ic21981040de379923d8a216a0f8fcf9b543072e6
Change-Id: I86989136f4b8baa51b399df4bed50b3edef4018d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants