-
Notifications
You must be signed in to change notification settings - Fork 662
[feat] [evaluate] openapi #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
(LogID: 2025092312090101009108820949935E9) Co-Authored-By: Coda <[email protected]>
(LogID: 2025092312090101009108820949935E9) Co-Authored-By: Coda <[email protected]>
(LogID: 2025092312090101009108820949935E9) Co-Authored-By: Coda <[email protected]>
service EvaluationOpenAPIService { | ||
// 评测集接口 (9个) | ||
// 1.1 创建评测集 | ||
CreateEvaluationSetOpenAPIResponse CreateEvaluationSet(1: CreateEvaluationSetOpenAPIRequest req) (api.post = "/open-apis/evaluation/v1/evaluation_sets") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
struct GetEvaluationSetOpenAPIRequest { | ||
1: required string workspace_id (api.js_conv="true", go.tag='json:"workspace_id"') | ||
2: required string evaluation_set_id (api.path = "evaluation_set_id") | ||
3: optional bool include_deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个include_deleted为什么要加呢~
2: required string name (vt.min_size = "1", vt.max_size = "255") | ||
3: optional string description (vt.max_size = "2048") | ||
4: optional eval_set.EvaluationSetSchema evaluation_set_schema | ||
5: optional string biz_category (vt.max_size = "128") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个biz_category感觉不需要让用户感知
|
||
// 评测集 | ||
struct EvaluationSet { | ||
1: optional string evaluation_set_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么不直接写id呢,还有EvaluationSetVersion里的version_id
|
||
// 1.1 创建评测集 | ||
struct CreateEvaluationSetOpenAPIRequest { | ||
1: required string workspace_id (api.js_conv="true", go.tag='json:"workspace_id"') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么设置了string呢
…ationSet, GetEvaluationSet, ListEvaluationSets (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
… convertor (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…ic to separate methods (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…rate methods (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…unified method parameter (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…error tracking (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…DTO/xxxDTO2DO convention (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…rchitecture (LogID: 20250928231227010091094121028E1E4) Co-Authored-By: Coda <[email protected]>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 62.76% 61.55% -1.22%
==========================================
Files 479 483 +4
Lines 52927 53963 +1036
==========================================
- Hits 33221 33218 -3
- Misses 17374 18412 +1038
- Partials 2332 2333 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
What type of PR is this?
openapi for evaluation
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: