[feat][backend] add search trace tree open api #217
+15,715
−8,905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_cc_trace_event_collector
…t_cc_trace_event_collector
…t_cc_trace_event_collector
…t_cc_trace_event_collector
(LogID: 20250930143228010091094197480C923) Co-Authored-By: Coda <[email protected]>
(LogID: 20250930162038010091094197293E3B5) Co-Authored-By: Coda <[email protected]>
…t_cc_trace_event_collector
…t_cc_trace_event_collector
(LogID: 202510141631250100910941971269738) Co-Authored-By: Coda <[email protected]>
(LogID: 202510141631250100910941971269738) Co-Authored-By: Coda <[email protected]>
(LogID: 20251014175401010091094197096B65A) Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda Co-Authored-By: Coda <[email protected]> (LogID: 2025101419340301009109419719038F1) Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda (LogID: 202510142136120100910941975788B9C) Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda
🤖 Generated with Coda Co-Authored-By: Coda <[email protected]> (LogID: 20251015121552010091094197109BD6B) Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda Co-Authored-By: Coda <[email protected]> (LogID: 20251015121552010091094197109BD6B) Co-Authored-By: Coda <[email protected]>
(LogID: 2025101517003901009109419764992EC) Co-Authored-By: Coda <[email protected]>
(LogID: 2025101517003901009109419764992EC) Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda Co-Authored-By: Coda <[email protected]> (LogID: 2025101517003901009109419764992EC) Co-Authored-By: Coda <[email protected]>
(LogID: 2025101517003901009109419764992EC) Co-Authored-By: Coda <[email protected]>
taoyifan89
reviewed
Oct 15, 2025
| defer func() { | ||
| if req != nil { | ||
| o.metrics.EmitTraceOapi("SearchTraceOApi", req.WorkspaceID, req.GetPlatformType(), "", int64(spansSize), errCode, st, err != nil) | ||
| o.collector.CollectTraceOpenAPIEvent(ctx, "SearchTraceOApi", req.WorkspaceID, req.GetPlatformType(), "", int64(spansSize), errCode, st, err != nil) |
There was a problem hiding this comment.
byteio上报到hive的，上线才能验证
| func (o *OpenAPIApplication) validateSearchTraceTreeOApiReq(ctx context.Context, req *openapi.SearchTraceTreeOApiRequest) error { | ||
| if req == nil { | ||
| return errorx.NewByCode(obErrorx.CommercialCommonInvalidParamCodeCode, errorx.WithExtraMsg("no request provided")) | ||
| } else if req.GetTraceID() == "" { |
| platformType := loop_span.PlatformType(req.GetPlatformType()) | ||
| if req.PlatformType == nil { | ||
| platformType = loop_span.PlatformCozeLoop | ||
| platformType = loop_span.PlatformDefault |
There was a problem hiding this comment.
default的配置和cozeloop都是一致的了是吧
There was a problem hiding this comment.
预期default是目前所有配置的最小公共部分，上线前我再ckeck下
| func (t *TraceConfigCenter) GetKeyColumns(ctx context.Context) []string { | ||
| keyColumns := make([]string, 0) | ||
| if err := t.UnmarshalKey(ctx, keyColumnsCfgKey, &keyColumns); err != nil { | ||
| return []string{"start_time", "span_id", "parent_id", "duration", "span_type", "span_name", "status_code", "tags_long", "logic_delete_date"} |
There was a problem hiding this comment.
search tree需要的字段。tcc配置。这里是在配置文件
| return keyColumns | ||
| } | ||
|
|
||
| func (t *TraceConfigCenter) GetKeySpanTypes(ctx context.Context) map[string]map[string][]string { |
There was a problem hiding this comment.
map[string]map[string][]string这种结构可读性太差了，是不是定义一个结构体出来
|
|
||
| import "github.com/samber/lo" | ||
|
|
||
| func getColumnStr(columns []string, omits []string) string { |
There was a problem hiding this comment.
这个是不是放到某个更通用的包里？和ck其实没关系，可能别的地方也会用到
| case loop_span.FieldTypeDouble: | ||
| return fmt.Sprintf("system_tags_float['%s']", filter.FieldName), nil | ||
| default: // not expected to be here | ||
| return fmt.Sprintf("tags_string['%s']", filter.FieldName), nil |
| return buf.String() | ||
| } | ||
|
|
||
| var spanColumns = []string{ |
| QueryType: ptr.Of(loop_span.QueryTypeEnumIn), | ||
| }) | ||
| } | ||
| filter.FilterFields = append(filter.FilterFields, &loop_span.FilterField{ |
| QueryEndTime int64 // ms | ||
| Tenant string | ||
| QueryTenants []string | ||
| SpanDoubleCheck bool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: