-
Notifications
You must be signed in to change notification settings - Fork 1
feat(pages): ListPage 작업 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- ListPage 구현했습니다. 상세 요구사항은 노션 요구사항 리스트에 작성해뒀습니다. - 카드 리스트 동적 추가, 반응형, 정렬기능 모두 구현했습니다.
… feature/listPage
jeonghwanJay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 현재는 수정 할 사항이 없어보입니다.!
테스트 해보고 만약 수정 사항이 있다면 말씀드리겠습니다.
너무 고생하셨습니다 !
zeon0xx0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
… feature/listPage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| let extraCount = totalUsers - maxVisible; | ||
| if (extraCount < 0) extraCount = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const extraCount = Math.max(totalUsers - maxVisibile, 0);
| <div className={styles.reactionsContainer}> | ||
| {badges.map((badge, index) => ( | ||
| <div key={index} {...badge} /> | ||
| <div key={index} {...badge} className={styles.badge}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div key={index} className={styles.badge} {...badge}>
| // 인기 섹션 좌우 이동 핸들러 | ||
| const handlePopularPrev = () => { | ||
| if (popularIndex > 0) { | ||
| setPopularIndex(popularIndex - 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
익명 화살표 함수를 넘겨 줘서 처리, updater function
setPopularIndex(prev => prev - 1)
| profileSection={dynamicProfileImages} | ||
| totalUsers={recipient.messageCount} | ||
| message={`To. ${recipient.name}`} | ||
| userMessage={`명이 작성했어요!`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
userMessage='명이 작성했어요!'
| const colorMapping = { | ||
| beige: "#FFE2AD", | ||
| purple: "#ECD9FF", | ||
| blue: "#B1E4FF", | ||
| green: "#D0F5C3", | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1(COLOR_TEXT):1(BACKGROUND_COLOR)
const COLOR_TEXT_BACKGROUND_COLOR_MAP = {
}
| const getHexColor = (apiColor) => { | ||
| return colorMapping[apiColor] || "#FFE2AD"; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const getHexColor = (colorText) => {
return colorMapping[colorText] || "#FFE2AD";
};| }; | ||
|
|
||
| const getHexColor = (apiColor) => { | ||
| return colorMapping[apiColor] || "#FFE2AD"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return colorMapping[apiColor] || DEFAULT_COLOR;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|| -> ??
| const fetchRecipients = async () => { | ||
| const res = await fetch("https://rolling-api.vercel.app/14-6/recipients/"); | ||
| if (!res.ok) throw new Error("데이터 불러오기 실패"); | ||
| const data = await res.json(); | ||
| return data.results || []; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api 계층은 별도 폴더에서 작성해주신 게 좋습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
폴더명
src/apis/fetchRecipients.js
src/remotes/fetchRecipients.js
#️⃣연관된 이슈
#61
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)