Multiple fix and improvement, mainly using correct query to get bike goal trips #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF-Cozy
requested review from
Merkur39,
paultranvan and
PolariTOON
as code owners
BundleMonFiles updated (2)
Unchanged files (2)
Total files change +13B 0% Final result: ✅ View report in BundleMon website ➡️ |
PolariTOON
reviewed
Nov 3, 2022
PolariTOON
approved these changes
Nov 3, 2022
Because of the way couch works, using elemMatch means that we don't rely on the index and so we browse the whole database. This is suboptimal. But it is a necessary discriminant. Another point, we delete the date selector here. This made sense if we had optimal queries, and then execute a query by year, when the year changes on the front. Finally, to know the dates to select, we have to go through all the trips anyway. With Paul we decided to make only one query and then to sort the data on the front.
since we already have it in the parent route we also relies on year url param and not on date provider
we now rely on url to get the year
isGoalCompleted and countDaysOrDaysToReach
JF-Cozy
force-pushed
the
feat/certificate
branch
from
8ef68b3
to
58e4777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voir le changelog ici, on corrige un multitude de souci