Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful notifications #2077

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Stateful notifications #2077

wants to merge 8 commits into from

Conversation

ptbrowne
Copy link
Contributor

@ptbrowne ptbrowne commented May 6, 2021

To remove the possibility of duplicate notifications, we send a state
to the stack at the same time that we send the notification. When a
notification is declared as stateful in the manifest, the stack will
not send a notification if it has the same state as the previous one.

This PR is in draft as we have to work more on the state that we want
to store. Particularly for balance lower alerts, it might be better
to store all balances for all accounts instead of only the balance
for accounts for which there are changed transactions.

Since we have to work more on the spec, this PR is deprioritized
in favor of the quickfix "not sending the notification for a change
of category".

@ptbrowne ptbrowne marked this pull request as draft May 6, 2021 09:57
@ptbrowne ptbrowne changed the title Draft: Stateful notifications Stateful notifications May 6, 2021
@ptbrowne
Copy link
Contributor Author

I still think it could be interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants