feat: Add instance data in loadInstanceOptionsFromStack #1380
+46
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
force-pushed
the
feat/add-instance-load-instance-options-from-stack
branch
from
26a726c
to
c897619
Compare
paultranvan
approved these changes
Aug 31, 2023
zatteo
force-pushed
the
feat/add-instance-load-instance-options-from-stack
branch
2 times, most recently
from
a55057b
to
1c62657
Compare
|
Related #1381 |
zatteo
force-pushed
the
feat/add-instance-load-instance-options-from-stack
branch
2 times, most recently
from
932276f
to
08c75c3
Compare
Crash--
reviewed
Aug 31, 2023
| @@ -1685,8 +1685,14 @@ instantiation of the client.` | |||
| Q('io.cozy.settings').getById('io.cozy.settings.capabilities') | |||
| ) | |||
|
|
|||
| const { data: instanceData } = await this.query( | |||
There was a problem hiding this comment.
Should be getOrFechFromState (I don’t know the name exactly) and you should add a fetchPolicy
There was a problem hiding this comment.
Updated. It should be always fresh so no fetchPolicy no?
There was a problem hiding this comment.
@zatteo I think using fetchQueryAndGetFromState as proposed by @Crash-- is only useful if we add a fetchPolicy. That being said, I'm not sure we want this kind of logic at this level, I don't think I like the idea of a forced fetchPolicy that could lead to unexpected results from the caller.
In any case, the behaviour should be the same for the other query just above on io.cozy.settings.capabilities.
There was a problem hiding this comment.
So :
- no fetchPolicy because we need it fresh
- same method for the two calls : decided to stay on query for the moment
zatteo
force-pushed
the
feat/add-instance-load-instance-options-from-stack
branch
from
08c75c3
to
367e354
Compare
zatteo
force-pushed
the
feat/add-instance-load-instance-options-from-stack
branch
from
367e354
to
1bfc6a0
Compare
zatteo
deleted the
feat/add-instance-load-instance-options-from-stack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need
localeattribute on flagship app.