Feat/add multiselection #940

Merkur39 · 2023-07-10T16:40:10Z

Ajout de la multi-sélection de contact (via la SelectionBar)
Ajout d'une nouvelle modale lors de la suppression d'un groupe, qui propose de supprimer également tous les contacts associés à ce groupe.

### ✨ Features

* Update cozy-ui from 81.1.0 to 88.1.1 (cca9655)
* Add **Select all** action (821ae9b / 6d2f512)
* Add new modal for delete contact group, allowing the choice to delete associated contacts.

### 🐛 Bug Fixes

* on mobile, back button should not return to modal url (e00ba18)

### 🔧 Tech

* Fixed flags not working for some time (55f7010)
* Update `eslint-config-cozy-app`, in order to be able to take advantage of the latest rules (715e55f)

And review the initialization of flags in the app

In order to be able to take advantage of the latest rules of `eslint-config-cozy-app`.

Which generated a warning in console

And split action to specific file

behind `select-all-contacts` flag

bundlemon · 2023-07-10T16:49:39Z

BundleMon

Files updated (5)

Status	Path	Size	Limits
✅	vendors/contacts.(hash).js	598.47KB (+4.76KB +0.8%)	-
✅	services/keepIndexFullNameAndDisplayNameUpToD ate/contacts.js	307.84KB (+3.96KB +1.3%)	-
✅	app-contacts.(hash).min.css	28.17KB (+716B +2.55%)	-
✅	intents/contacts.(hash).js	28.37KB (+517B +1.81%)	-
✅	app/contacts.(hash).js	282.81KB (-39B -0.01%)	-

Unchanged files (2)

Status	Path	Size	Limits
✅	public/contacts.(hash).js	44.54KB	-
✅	img/icon.(hash).svg	453B	-

Total files change +9.89KB +0.77%

Groups updated (2)

Status	Path	Size	Limits
✅	*/.js	2.07MB (+9.19KB +0.44%)	-
✅	*/.css	102.39KB (-799B -0.76%)	-

Unchanged groups (1)

Status	Path	Size	Limits
✅	img/.	453B	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

src/components/Contexts/ContactsDiplayed.jsx

Crash-- · 2023-07-11T07:37:09Z

src/components/ContentResult.jsx

@@ -72,7 +74,8 @@ export const ContentResult = ({ contacts, allGroups }) => {
      searchValue
    )
    setFilteredContacts(filteredContactsBySearch)
-  }, [contacts, searchValue, selectedGroup, setFilteredContacts])
+    setContactsDisplayed(filteredContactsBySearch)
+  }, [contacts, searchValue, selectedGroup, setContactsDisplayed])


What is the difference between filteredContacts and ContactsDisplayed?

Aucune, si ce n'est que ContactsDisplayed est accessible pour tous les composants (ContactsSelectionBar aujourd'hui)

Dans ce cas, pourquoi en créer un nouveau ? On devrait rendre accessible ce ContactsDisplayed partout, non ?

setFilteredContacts est un état local déjà présent et surtout initialisé avec les contacts traités par son parent.
De part l'archi actuelle, le remplacer ici par le contexte ContactsDisplayed, fait apparaitre un instant le composant ContactsEmptyList (même problème en utilisant le contexte dans le parent)

Je n'ai pas de solution viable rapide, et je dois reprendre d'autres développements, mais à l'écoute si jamais !

Je valide pour avancer, mais ça me dérange fortement cette duplication.

src/queries/queries.js

src/connections/allContacts.js

src/locales/fr.json

This context is useful to keep in memory the contacts displayed, this will allow for example to select only these, because they could be filtered beforehand.

And use `queryAll` instead `query`

Ad add option parameter

And removed the use of react-redux because it's not used, and is no longer relevant.

We want to offer the choice to delete the contacts associated with the group that we want to delete.

And removed the old approach which became useless

Merkur39 · 2023-07-11T13:57:13Z

@Crash-- Retours effectués 👍

Merkur39 added 6 commits July 4, 2023 16:10

fix: Flags usages

55f7010

And review the initialization of flags in the app

feat: Update cozy-ui from 81.1.0 to 88.1.1

cc200cd

feat: Update eslint-config-cozy-app and others peerDeps

e9da059

In order to be able to take advantage of the latest rules of `eslint-config-cozy-app`.

fix: The buildIdentitiesQueryByContact parameter is not always boolean

3ad58da

Which generated a warning in console

refactor: Migration of the ContactsSelectionBar component in function

15f508f

And split action to specific file

feat: Remove unused "select all" button

4b809e1

behind `select-all-contacts` flag

Merkur39 requested a review from JF-Cozy as a code owner July 10, 2023 16:40