Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update cozy deps #1965

Merged
merged 1 commit into from
Jul 3, 2023
Merged

feat: Update cozy deps #1965

merged 1 commit into from
Jul 3, 2023

Conversation

Merkur39
Copy link
Member

And apply all BC

And apply all BC
@bundlemon
Copy link

bundlemon bot commented Jun 30, 2023

BundleMon

Files updated (7)
Status Path Size Limits
vendors/home.(hash).js
1.21MB (+3.54KB +0.29%) 1.5MB
services/updateAccounts/home.js
459.69KB (+3.42KB +0.75%) 464KB
services/softDeleteOrRestoreAccounts/home.js
483.76KB (+3.38KB +0.7%) 487KB
app/home.(hash).js
42.25KB (+24B +0.06%) 43KB
services/deleteAccounts/home.js
318.45KB (+20B +0.01%) 500KB
app-home.(hash).min.css
14.3KB (-104B -0.71%) 15KB
vendors-home.(hash).(hash).min.css
31.46KB (-169B -0.52%) 35KB
Unchanged files (6)
Status Path Size Limits
services/myselfFromIdenties/home.js
233.95KB 235KB
services/polyfillFetch/home.js
98.39KB 99KB
intents/home.(hash).js
33.57KB 35KB
services/attributesHelpers/home.js
15.13KB 16KB
intents-home.(hash).min.css
5.78KB 6KB
intents/index.html
500B 1KB

Total files change +10.12KB +0.34%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Merkur39
Copy link
Member Author

Je vous laisse merge au besoin :)

@Crash-- Crash-- merged commit ec3c0cd into master Jul 3, 2023
4 checks passed
@Crash-- Crash-- deleted the feat/Update-cozy-deps branch July 3, 2023 06:07
@Crash--
Copy link
Contributor

Crash-- commented Jul 3, 2023

Première erreur:

instrument.js:109 Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `LogoutDialog`.

Effectivement, j'ai un import { Button } from 'cozy-ui/transpiled/react/Button' sauf qu'on exporte default, donc je devrais avoir un import Button from 'cozy-ui/transpiled/react/Button . Sauf que quand je fais ça, mon bouton s'affiche très mal.

j'ai fait #1967

@JF-Cozy
Copy link
Contributor

JF-Cozy commented Jul 3, 2023

ça aurait dû marcher, le fichier est resté inchangé et on a bien également https://github.com/cozy/cozy-ui/blob/master/react/deprecated/Button/index.jsx#L121 🤔

J'ai testé le codemods il transforme bien import { Button } from 'cozy-ui/transpiled/react/Button' en import { Button } from 'cozy-ui/transpiled/react/deprecated/Button'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants