Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render null if konnector not in registry #1970

Merged

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Jul 6, 2023

If there is no registry data it is better to render nothing
because we won't have any link to the Konnector,
despite having its slug.
This is because failing to get the data most likely means
that the Service is not available
on the current registry (404 Not Found).
It is not a problem if the Service is not available on the registry,
but it is a problem if we try to link to it.
Here it would display an AppLinker with a grey cube,
an unformatted slug as a name and no working link.

If there is no registry data it is better to render nothing
because we won't have any link to the Konnector,
despite having its slug.
This is because failing to get the data most likely means
that the Service is not available
on the current registry (404 Not Found).
It is not a problem if the Service is not available on the registry,
but it is a problem if we try to link to it.
Here it would display an AppLinker with a grey cube,
an unformatted slug as a name and no working link.
@acezard acezard requested a review from doubleface as a code owner July 6, 2023 14:04
@acezard acezard requested a review from Crash-- July 6, 2023 14:14
@bundlemon
Copy link

bundlemon bot commented Jul 6, 2023

BundleMon

Files updated (7)
Status Path Size Limits
app/home.(hash).js
42.27KB (+25B +0.06%) 43KB
intents/home.(hash).js
33.59KB (+25B +0.07%) 35KB
services/deleteAccounts/home.js
318.31KB (-141B -0.04%) 500KB
services/updateAccounts/home.js
459.55KB (-145B -0.03%) 464KB
services/softDeleteOrRestoreAccounts/home.js
483.62KB (-152B -0.03%) 487KB
services/myselfFromIdenties/home.js
233.75KB (-204B -0.09%) 235KB
vendors/home.(hash).js
1.21MB (-590B -0.05%) 1.5MB
Unchanged files (6)
Status Path Size Limits
services/polyfillFetch/home.js
98.39KB 99KB
vendors-home.(hash).(hash).min.css
31.46KB 35KB
services/attributesHelpers/home.js
15.13KB 16KB
app-home.(hash).min.css
14.3KB 15KB
intents-home.(hash).min.css
5.78KB 6KB
intents/index.html
501B 1KB

Total files change -1.15KB -0.04%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@acezard acezard merged commit cfe73cb into master Jul 6, 2023
4 checks passed
@acezard acezard deleted the fix--render-null-as-fallback-if-konnector-not-in-registry branch July 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants