Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove brightness filter on secondary footer logos #2173

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Jul 30, 2024

We had previously done this thinking that it would be generic to all partners, but it is specific to some. We're also adding css classes to better control these elements on the partner side.

### 🐛 Bug Fixes

* Remove brightness filter on secondary footer logos

We had previously done this thinking that it would be generic to all partners, but it is specific to some. We're also adding css classes to better control these elements on the partner side.
Copy link
Member

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

bundlemon bot commented Jul 30, 2024

BundleMon

Files updated (1)
Status Path Size Limits
intents/home.(hash).js
25.42KB (+11B +0.04%) 35KB
Unchanged files (12)
Status Path Size Limits
vendors/home.(hash).js
1.48MB 1.5MB
services/softDeleteOrRestoreAccounts/home.js
463.5KB 490KB
services/updateAccounts/home.js
460.62KB 467KB
services/deleteAccounts/home.js
308.86KB 500KB
services/myselfFromIdenties/home.js
233.45KB 245KB
services/polyfillFetch/home.js
97.37KB 99KB
app/home.(hash).js
44.25KB 50KB
vendors-home.(hash).(hash).min.css
38.77KB 40KB
services/attributesHelpers/home.js
15.22KB 16KB
app-home.(hash).min.css
1.78KB 15KB
intents/index.html
651B 1KB
intents-home.(hash).min.css
158B 6KB

Total files change +5B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@JF-Cozy JF-Cozy merged commit 763eed2 into master Jul 30, 2024
3 checks passed
@JF-Cozy JF-Cozy deleted the feat/VER-778 branch July 30, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants