Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VO-1064 & VO-1067] feat: Take into account feedback on announcements #2184

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

cballevre
Copy link
Member

List of change onto announcements :

  • Change the way seen works
  • Limit the number of announcement displayed simultaneously to 5
  • Show announcements only 1h after the first time the feature is activated

There is more context into each commit message

Previously, announcements was considered to have been seen when it appeared. Now, it's when the user decides to move on to the next announcement that the one displayed is considered to have been seen.
Before the API was limiting the number of response. This limit has been removed so that users can go 5 by 5 through the announcement they haven't seen yet.
To avoid spamming the interface with new users, we're putting a delay between the first opening of the Home and the appearance of the announcements dialog.
Copy link

bundlemon bot commented Sep 13, 2024

BundleMon

Files updated (1)
Status Path Size Limits
app/home.(hash).js
47.33KB (+127B +0.26%) 50KB
Unchanged files (12)
Status Path Size Limits
vendors/home.(hash).js
1.5MB 1.6MB
services/softDeleteOrRestoreAccounts/home.js
464.31KB 490KB
services/updateAccounts/home.js
461.37KB 467KB
services/deleteAccounts/home.js
309.73KB 500KB
services/myselfFromIdenties/home.js
234.26KB 245KB
services/polyfillFetch/home.js
97.38KB 99KB
vendors-home.(hash).(hash).min.css
38.77KB 40KB
intents/home.(hash).js
25.51KB 35KB
services/attributesHelpers/home.js
15.23KB 16KB
app-home.(hash).min.css
1.78KB 15KB
intents/index.html
650B 1KB
intents-home.(hash).min.css
158B 6KB

Total files change +127B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@cballevre cballevre merged commit 508a115 into master Sep 18, 2024
3 checks passed
@cballevre cballevre deleted the feat/announcements-feedback branch September 18, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants