Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assistant: Better management of providers, routes and browser back button #2228

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Assistant: Better management of providers, routes and browser back button #2228

merged 3 commits into from
Oct 28, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Oct 28, 2024 •
edited
Loading

No description provided.

@JF-Cozy
feat(Assistant): Use conversationId from url instead of state context
bdde8e3 
to be able to empty it, and to have sort of history
@JF-Cozy
fix(Assistant): SearchProvider was too high level
4592f61 
and required a clear method for navigation (modal closure). Except that this method cannot be called when back browser action...
@JF-Cozy
fix(Assistant): Don't clear provider when navigating
34e4080 
we should not use clear providers method in combination with navigation, because the behavior will be different when using back browser button
@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 28, 2024

BundleMon

Files updated (2)
Status Path Size Limits
✅ app/home.(hash).js
 55.71KB (-114B -0.2%) -
✅ intents/home.(hash).js
 27.38KB (-1.81KB -6.21%) -
Unchanged files (11)
Status Path Size Limits
✅ vendors/home.(hash).js
 1.54MB -
✅ services/softDeleteOrRestoreAccounts/home.js
 464.4KB -
✅ services/updateAccounts/home.js
 461.47KB -
✅ services/deleteAccounts/home.js
 309.8KB -
✅ services/myselfFromIdenties/home.js
 234.35KB -
✅ services/polyfillFetch/home.js
 97.37KB -
✅ vendors-home.(hash).(hash).min.css
 38.79KB -
✅ services/attributesHelpers/home.js
 15.22KB -
✅ app-home.(hash).min.css
 2.18KB -
✅ intents/index.html
 650B -
✅ intents-home.(hash).min.css
 158B -

Total files change -1.93KB -0.06%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@JF-Cozy JF-Cozy merged commit fb001fc into master Oct 28, 2024
4 checks passed
@JF-Cozy JF-Cozy deleted the feat/VER-1033 branch October 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldoppea Ldoppea Ldoppea approved these changes

@cballevre cballevre Awaiting requested review from cballevre cballevre is a code owner

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JF-Cozy @Ldoppea