Fix some errors #182
Merged
Fix some errors #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
changed the title
zatteo
changed the title
zatteo
force-pushed
the
feat/update-cozy-client
branch
from
002ca1a
to
b9ea586
Compare
Ldoppea
approved these changes
Apr 19, 2024
| @@ -0,0 +1 @@ | |||
| <span aria-hidden="true"> · {{ this.stringifiedLabel }}</span> | |||
There was a problem hiding this comment.
Don't we want the label to be read by screen readers?
There was a problem hiding this comment.
My bad. Fixed by creating two span 👍 (one hidden for the bullet and one visible for the label).
Comment on lines
22
to
24
| this.stringifiedLabel = `${this.getTranslatedType( | ||
| this.label.type | ||
| )} (${this.getTranslatedLabel(this.label.label).toLowerCase()})`; |
There was a problem hiding this comment.
nit: extracting the two translations into variables would improve readability of the templated string
zatteo
force-pushed
the
feat/update-cozy-client
branch
from
b9ea586
to
e484013
Compare
When we tried to improve performance by passing the key directly to convertContactToCipherResponse, we introduce inversion in arguments passed to convertContactToCipherResponse.
conversion fail Previously, when converting papers or contacts to ciphers, we were returning an empty array when an error occured. So with 1000 contacts, if one conversion failed, we were seeing 0 contact. Now we will see the 999 contacts that were successfully converted and we will log an error for each paper or contact that failed to be converted.
zatteo
force-pushed
the
feat/update-cozy-client
branch
from
e484013
to
3e718c3
Compare
io.cozy.contacts label management has been improved. A phone number, an address or an email can have : - a type which can be "cell", "voice", "fax" or a custom string - a label which can be "home" or "work" - both See io.cozy.contacts documentation to learn more. Here we introduce and use a new component to display correctly the label value. We also modify our types to correspond to io.cozy.contacts.
zatteo
force-pushed
the
feat/update-cozy-client
branch
from
3e718c3
to
0d0abc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.