[VER-446] fix: Correctly logout OAuth client on logout notification #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a logout we wan't the extension to also logout the Cozy's Oauth client This was done from the `runtime.background.ts` file so the action is done when the user clicks on the Settings logout button But this is not the only scenario that can produce a logout This is the case when the user changes their password from cozy-settings. In that scenario, the cozy-stack will send a `logout` notification to the Bitwarden's realtime stream, and so the extension will react by doing a logout To have the OAuth logout on both scenario we want to move the related code into `main.background.ts`
Ldoppea
changed the title
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a logout we wan't the extension to also logout the Cozy's Oauth client
This was done from the
runtime.background.tsfile so the action is done when the user clicks on the Settings logout buttonBut this is not the only scenario that can produce a logout
This is the case when the user changes their password from cozy-settings. In that scenario, the cozy-stack will send a
logoutnotification to the Bitwarden's realtime stream, and so the extension will react by doing a logoutTo have the OAuth logout on both scenario we want to move the related code into
main.background.ts