[VER-507] fix: Correctly display Konnectors icons after closing/reopenning the extension's popup #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
changed the title
KonnectorsOrganization is currently saved in the account InMemory storage as an object We found that this may produce DeadObjects errors on Firefox due to the way it manage memory Exemple scenario for reproducing this problem: open the Cozy Connectors folder, close the extension popup and re-open it. The ciphers will lose their "shared with Cozy" icons and the `can’t access dead object` error should appear in the devtools We found that storing the info in the account as a string instead of an object would prevent the issue to happen We could have also use `defaultOnDiskOptions` instead of `defaultInMemoryOptions` to save the `KonnectorsOrganization` data, but the string option seems to have less possible side effects Related link: https://blog.mozilla.org/addons/2012/09/12/what-does-cant-access-dead-object-mean/
Ldoppea
force-pushed
the
fix/konnector_icon
branch
from
aac2308
to
8b736fe
Compare
zatteo
approved these changes
Apr 25, 2024
|
The second commit talks about |
CipherRowComponent is displayed with a *cdkVirtualFor loop. As stated in the documentation, "To improve rendering performance, *cdkVirtualFor caches previously created views after they are no longer needed. When a new view would normally be created, a cached view is reused instead." So we can not set the isKonnector in ngOnInit because it will keep the value of the first elements created Related commit: 14338fe
Ldoppea
force-pushed
the
fix/konnector_icon
branch
from
8b736fe
to
3215c95
Compare
Yes sorry, i copy pasted your commit message. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KonnectorsOrganization is currently saved in the account InMemory storage as an object
We found that this may produce DeadObjects errors on Firefox due to the way it manage memory
Exemple scenario for reproducing this problem: open the Cozy Connectors folder, close the extension popup and re-open it. The ciphers will lose their "shared with Cozy" icons and the
can’t access dead objecterror should appear in the devtoolsWe found that storing the info in the account as a string instead of an object would prevent the issue to happen
We could have also use
defaultOnDiskOptionsinstead ofdefaultInMemoryOptionsto save theKonnectorsOrganizationdata, but the string option seems to have less possible side effectsRelated link:
https://blog.mozilla.org/addons/2012/09/12/what-does-cant-access-dead-object-mean/