Sync in the same time bitwarden and cozy ciphers #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
changed the title
Instead of doing 1 replace for bitwarden ciphers and 2 upsert for cozy ciphers, we update syncCiphers method to accept our cozy ciphers. So 1 replace will be enough for bitwarden and cozy ciphers and it is faster.
zatteo
force-pushed
the
feat/improve-sync-perf
branch
from
6734fef
to
4f73250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing 1 replace for bitwarden ciphers and 2 upsert for cozy ciphers, we update syncCiphers method to accept our cozy ciphers. So 1 replace will be enough for bitwarden and cozy ciphers and it is faster.