Foundation of paper autofilling paper data with id card number #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we autofill a contact, we want to be able to autofill data from papers of the contact. The first candidate is id card number from national_id_card. So let's add a new test form to have a goal to reach.
It will be needed soon to make CozyClient query from AutofillService.
zatteo
commented
Jul 19, 2024
zatteo
force-pushed
the
feat/autofill-id-card
branch
from
bf2d065
to
489f121
Compare
paultranvan
reviewed
Jul 22, 2024
| "Official identification number", | ||
| "Personal registration number", | ||
| ]; | ||
| } |
There was a problem hiding this comment.
That's a huge list 😮 You did it yourself?
There was a problem hiding this comment.
No, it is our awesome product owner.
There was a problem hiding this comment.
Nice, but I wonder if it's worth the effort to do it for every type of data. And also, I tend to think that we should do it with real-case examples, as:
- it will avoid trying to imagine all possible cases
- we should be careful with false positive: typically "Personal identifier" seems rather generic and not related to french ID card (also, it's worth questioning the need to support english keywords for very-french data such as this one).
What do you think @BenjaminMty ?
apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts
Outdated
Show resolved
Hide resolved
We introduce : - COZY_ATTRIBUTES_MAPPING, a mapping modelizing the link between a Bitwarden field type and what we need to get the corresponding data from Cozy doctypes - getCozyValue, the main function that interpret the mapping and retrieve the corresponding data from Cozy doctypes For the moment only id card number is added.
These constants are used by the autofill feature to know if a field should be filled by some data. For the moment only id card number is added.
…d number This new fillscript generation step enhances the fillscript already created for a contact. It will fill data from papers. For the moment only id card number is added.
Bad compare of uppercase and lowercase
zatteo
force-pushed
the
feat/autofill-id-card
branch
from
489f121
to
b5bc952
Compare
paultranvan
reviewed
Jul 22, 2024
|
|
||
| const papersFromContact = papers.filter((paper: any) => isReferencedByContact(paper, contactId)); | ||
|
|
||
| return _.get(papersFromContact[0], cozyAttributeModel.path); |
There was a problem hiding this comment.
It means that if I add my national id card but skip the contact part for any reason, it won't work? I wonder if we should try to fallback on myself by default?
paultranvan
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Some open questions, but nothing blocking, thank you @zatteo!
Merkur39
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Well done!
Thanks @paultranvan, I'm going to merge so I can continue the development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I add the foundation of autofilling paper data when autofilling a contact by taking as example the id card number.
Screen.Recording.2024-07-19.at.17.33.45.mov
The paper data autofill expand the fillscript of a contact.
Tested :