Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more paper data in autofill #225

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

zatteo
Copy link

@zatteo zatteo commented Jul 25, 2024

It is still very verbose, but for the moment I think that it is not the moment to factorize the code :

  • we still do not know if there will be edge cases
  • it is also verbose on Bitwarden side, so I do not want to factorize only part of the code, or I do not want to factorize their code, to avoid merge upstream conflict

Added

Numéro de passport
Numéro de titre de séjour
Numéro de carte grise
Code ANTS
Plaque d'immatriculation
IBAN
BIC
Numéro fiscal
Revenu fiscal de référence

@zatteo zatteo changed the base branch from feat/stream2-part2 to feat/ver-581 August 23, 2024 14:54
@zatteo zatteo force-pushed the feat/add-more-paper-data branch 3 times, most recently from ad64c24 to 709cb23 Compare August 26, 2024 07:26
Comment on lines 31 to 33
paperVehiculeRegistrationNumber: "paperVehiculeRegistrationNumber",
paperVehiculeRegistrationConfidentialCode: "paperVehiculeRegistrationConfidentialCode",
paperVehiculeRegistrationLicensePlateNumber: "paperVehiculeRegistrationLicensePlateNumber",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> ...vehicle... (Here and elsewhere)

Numéro de passport
Numéro de carte vitale
Numéro de titre de séjour
Numéro de carte grise
Code ANTS
Plaque d'immatriculation
IBAN
BIC
Salaire brut
Salaire net
Numéro fiscal
Revenu fiscal de référence
@zatteo zatteo merged commit 8b400c5 into feat/ver-581 Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants