Feat: Hide Bitwarden redirections & pop out feature #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
approved these changes
Aug 8, 2024
This component is a new Bitwarden feature that we do not wish to offer at this time.
zatteo
added a commit
that referenced
this pull request
Aug 19, 2024
commit 9a89a3b9b0ad3864ff18bd651c03f3382f15c93b Author: Ldoppea <[email protected]> Date: Tue Aug 13 10:05:14 2024 +0200 fix: Remove duplicate TOTP entry in locales commit 07e0998cf1a6cd0cefbc390f7b0612885fc7a9ee Author: Ldoppea <[email protected]> Date: Mon Aug 12 17:46:20 2024 +0200 feat: Improve build workflow to upload sources in artifacts commit 6c5b989aa681efeb8d554ac962c9fb86cfbf1c94 Author: Ldoppea <[email protected]> Date: Mon Aug 12 17:44:12 2024 +0200 fix: Fix create-archive.sh commit 45a99b337548f4a5b5c6368051aaf1e50a42a03c Author: Ldoppea <[email protected]> Date: Mon Aug 12 17:38:30 2024 +0200 fix: Remove duplicate entries in locales Those entries did already exist somewhere in the file so we remove them commit f7ee73a4ff60128648eebee0bd96426ea5735de9 Author: AlexisG <[email protected]> Date: Fri Aug 9 17:09:03 2024 +0200 chore: Bump 2.1.0 commit eab42bfde06def260e5fa3e62621cf0ec1575773 Author: AlexisG <[email protected]> Date: Fri Aug 9 17:07:12 2024 +0200 chore: Bump 2.0.1 commit 2e79c188e65f1f692b82b1c21ddd9cc8fd7c6bd3 Author: AlexisG <[email protected]> Date: Fri Aug 9 17:03:40 2024 +0200 fix: Update Firefox min version to publish Mozilla Addons requires Firefox min version >= 58.0. We set the version of the Bitwarden merge upstream which is 91.0 commit fb9636326c50e5a8c2f2e72d5e71c2adc1010e7c Merge: f0ec384c1d b09604aab4 Author: Alexis G <[email protected]> Date: Fri Aug 9 15:25:03 2024 +0200 Merge pull request #233 from cozy/fix/Logins-before-every-other-types-in-search-result fix: Logins before every other types in search result commit b09604aab4d04876818d0c1a9f4b367a1cc269ac Author: Ldoppea <[email protected]> Date: Fri Aug 9 14:48:42 2024 +0200 feat: Restore Cozy's navigation history feature In #149 we implemented the History feature that allowed to restore the popup's current page after closing and re-opening it Since last merge upstream, we lost this feature due to the fact that Bitwarden did rewrite their router implementation The `UnauthGuardService` is not used anymore when opening the popup. Instead `redirectGuard()` and `unauthGuardFn()` functions are used Those methods don't have access to the HistoryService so we cannot copy the old code into those new functions To fix this, we want to create a new `RestoreHistory` component that will be the new "default" route called when opening the popup. Then this component will call the HistoryService to restore the correct route from the history commit 601eb41bb537f2c0eef6d64e25e393fd47baf30e Author: AlexisG <[email protected]> Date: Fri Aug 9 10:00:10 2024 +0200 fix: Logins before every other types in search result Applying this commit after merge upstream 8b57bdb commit f0ec384c1d01652cda27b9e82e95ba25d921ed33 Merge: 7331e00e78 b34576c465 Author: Alexis G <[email protected]> Date: Thu Aug 8 16:57:10 2024 +0200 Merge pull request #232 from cozy/fix/ver-794 fix: Hide cross close button in search bar commit b34576c4657d873e1c4e3e93958fd4e1064116d0 Author: AlexisG <[email protected]> Date: Thu Aug 8 16:51:36 2024 +0200 fix: Hide cross close button in search bar Already have a clear button. commit 7331e00e78d13fd9be2538930920fdfc5af3d346 Merge: b440d53005 a37a162473 Author: Alexis G <[email protected]> Date: Thu Aug 8 15:24:34 2024 +0200 Merge pull request #231 from cozy/fix/ver-792 fix: Duplicate toast informations commit a37a1624730af048633dadf6b1a8b35bf387bb06 Author: AlexisG <[email protected]> Date: Thu Aug 8 15:09:54 2024 +0200 fix: Duplicate toast informations Some toasts display the same information twice. This change ensures that only the title is displayed in these toasts, giving the user a cleaner, more concise experience. commit b440d53005d2cb5f35a205820841c7fdc25b871b Merge: dcf0d0929c a7051b084b Author: Alexis G <[email protected]> Date: Thu Aug 8 12:09:33 2024 +0200 Merge pull request #230 from cozy/fix/ver-793 Feat: Hide Bitwarden redirections & pop out feature commit a7051b084bee72a7e95f1ef47af71e180c096b57 Author: AlexisG <[email protected]> Date: Thu Aug 8 11:36:14 2024 +0200 feat: Hide Bitwarden redirects commit 392f434f776ba58496462676e370ce6455f71cec Author: AlexisG <[email protected]> Date: Thu Aug 8 11:35:23 2024 +0200 feat: Hide all "<app-pop-out>" component This component is a new Bitwarden feature that we do not wish to offer at this time. commit dcf0d0929cdfb9be71bdbb9213923f8a1ee73f8d Merge: daaf04f8a9 53393522c7 Author: Alexis G <[email protected]> Date: Wed Aug 7 17:46:08 2024 +0200 Merge pull request #229 from cozy/feat/ver-782 Multiple adjustments for the Stream 2 branch commit 53393522c7896546c0b14fcb9095d01c8b5161be Author: AlexisG <[email protected]> Date: Wed Aug 7 17:26:06 2024 +0200 feat: Paper editing returns to the new MesPapiers editing route commit fe0087c19358d8a7547f7b508f39f346cba6c64b Author: AlexisG <[email protected]> Date: Tue Aug 6 16:34:21 2024 +0200 feat: Hide "lock all" Bitwarden feature commit ea49c5f38fb7887b352a581d056a6e8f35838c57 Author: AlexisG <[email protected]> Date: Tue Aug 6 16:26:38 2024 +0200 feat: Hide link of "autofill help" option commit a3f2740b870c63214c7748a9e34042584db487b6 Author: AlexisG <[email protected]> Date: Tue Aug 6 16:09:05 2024 +0200 feat: Replace some Bitwarden occurence by Cozy commit d08b0575234f0d09ae098dd6495a5b70912bc337 Author: AlexisG <[email protected]> Date: Tue Aug 6 15:14:41 2024 +0200 fix: Open cozy mailto link when "contact support" is clicked commit 1148fb33a05f7cd046a39eb66119fa275b4583b7 Author: AlexisG <[email protected]> Date: Tue Aug 6 15:06:44 2024 +0200 fix: Add lightContrasted option omitted in upstream merge commit 03b43f605c6e814b6fd1ecc2c30b6563c1bcdbf1 Author: AlexisG <[email protected]> Date: Tue Aug 6 14:37:51 2024 +0200 feat: Disable redirect link on the Setting header We'd like to hide the button that opens the extension in a new window. commit daaf04f8a9b4dd63f5db72ac25f8490bcfc995c2 Merge: 10aa6f22c1 bc232ec344 Author: Alexis G <[email protected]> Date: Thu Aug 1 14:35:59 2024 +0200 Merge pull request #228 from cozy/fix/redirect-cozy fix: Redirect button to the Cozy commit bc232ec34457a05217475bf3513dc69212f09a7b Author: AlexisG <[email protected]> Date: Thu Aug 1 11:13:20 2024 +0200 fix: Redirect button to the Cozy Since the merge upstream, the method of retrieving the cozy URL has changed. (see 4a2dee6) The new approach was not functional. As the `this.webVaultUrlSync` property defines its value in an async method, when `getCozyURL()` is called `this.webVaultUrlSync` is not yet set. commit 10aa6f22c1796c3deb76af46d7ae13536c864146 Merge: e8320b4c1c 8d0508fa78 Author: Théo Poizat <[email protected]> Date: Wed Jul 17 16:42:37 2024 +0200 Merge pull request #220 from cozy/feat/inpagemenustyle feat: Change inline menu style for contact list commit 8d0508fa7835347a175fc9d9b9e113b39f97ce44 Author: Théo Poizat <[email protected]> Date: Wed Jul 17 16:14:46 2024 +0200 test: Mock all cozy-ui files We do not need to test cozy-ui methods. To avoid SyntaxError: Cannot use import statement outside a module > 67 | import { nameToColor } from "cozy-ui/transpiled/react/Avatar/helpers"; commit 2e60728ae6040054480f5b685faf535a232cf84e Author: AlexisG <[email protected]> Date: Wed Jul 17 10:41:20 2024 +0200 feat: Replace viewCipherIcon in the inline menu commit 48f94042ea05bd8d1b4c65f3259845144026a214 Author: AlexisG <[email protected]> Date: Wed Jul 17 15:35:05 2024 +0200 feat: Add attributes to the cipher contact inline menu And use them to customize inline menu styles commit 33ca2364f8155f806fab5d8d659ddca81310a9dc Author: AlexisG <[email protected]> Date: Wed Jul 17 10:27:03 2024 +0200 feat: Add Lato webfont in libs style file commit 0914124409b6790413c13ff2a5c3af14edb07d28 Author: Théo Poizat <[email protected]> Date: Tue Jul 16 15:35:12 2024 +0200 feat: Update inline menu border to fit cozy style commit e8320b4c1c113684d506fa7934334f10f75f2483 Merge: a18adc5d99 528e59c828 Author: Théo Poizat <[email protected]> Date: Wed Jul 17 15:31:16 2024 +0200 Merge pull request #216 from cozy/feat/inpagemenu Credit card and contact autofill in inline menu commit 528e59c828d7d409ac65f376804c733287d85cf2 Author: Théo Poizat <[email protected]> Date: Wed Jul 17 14:03:53 2024 +0200 Revert "test: Run test in band" This reverts commit 30c7fc00f3ed53887613133083cb9eb195aaa0da. commit d154e633d09f476a417994b36907a9a0ca1c93c3 Author: Théo Poizat <[email protected]> Date: Wed Jul 17 13:51:58 2024 +0200 test: Fix autofill overlay test commit 9589d35da7120f92ca7e948bd15c818cc5e90859 Merge: 30c7fc00f3 5f34c871ca Author: Théo Poizat <[email protected]> Date: Wed Jul 17 13:30:16 2024 +0200 Merge branch 'autofill/pm-2858-identities-inline-menu-autofill' into feat/inpagemenu commit 30c7fc00f3ed53887613133083cb9eb195aaa0da Author: Théo Poizat <[email protected]> Date: Wed Jul 17 11:53:11 2024 +0200 test: Run test in band commit ed5c5c8641035081f70f22e32c956057947347cc Author: Théo Poizat <[email protected]> Date: Wed Jul 17 11:45:12 2024 +0200 fix: Remove two warnings in state.service.ts commit a7c36c3c62013f5cd499c74d26674425f7987333 Author: Théo Poizat <[email protected]> Date: Wed Jul 17 11:43:53 2024 +0200 test: Fix tests after 2024.5.1 or 2024.6.3 merge upstream commit 9ff5e6c8e3abb7e94f5af0d8fea40a866180c596 Author: Théo Poizat <[email protected]> Date: Tue Jul 16 18:46:12 2024 +0200 feat: Pass lint after 2024.5.1 or 2024.6.3 merge upstream commit 5464fbbf0bbea8d568bbefcb4f1bacfcd7df2332 Author: Théo Poizat <[email protected]> Date: Tue Jul 16 18:28:04 2024 +0200 chore: Add node-pre-gyp to ci argon2 build seems to need it. commit d6b8eb556edef25c95ef0f5b3f0f7a7f75b6be3e Author: Théo Poizat <[email protected]> Date: Tue Jul 16 18:22:15 2024 +0200 feat: Update package.lock commit 33527334b4d8074461ae0724fad834f90ec50d7f Author: Théo Poizat <[email protected]> Date: Tue Jul 16 17:30:50 2024 +0200 feat: Run prettier after 2024.5.1 or 2024.6.3 merge upstream commit 1eef67f80e06a907cf36bbd1a2360e1e09fd0420 Author: Théo Poizat <[email protected]> Date: Tue Jul 16 17:30:32 2024 +0200 chore: Bring back GitHub workflow They have been lost during 2024.5.1 or 2024.6.3 merge upstream. Also updated nodejs version. commit 5f34c871ca947c064f64f3f9acbbe1c784865cf7 Merge: 176ac2169f 2409e69991 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 14:34:32 2024 -0500 Merge branch 'autofill/pm-2857-inline-menu-credit-card-autofill' into autofill/pm-2858-identities-inline-menu-autofill commit 2409e699919dbc46228e0b835370e85a6b1edd7b Merge: 5df6e7aad6 1103e1312a Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 14:34:23 2024 -0500 Merge branch 'autofill/pm-8207-cannot-use-keyboard-with-scribe-extension' into autofill/pm-2857-inline-menu-credit-card-autofill commit 1103e1312a390fdf57a0fbe1a3b56176668c5d98 Merge: 33c3553aa2 154f15fa58 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 14:34:11 2024 -0500 Merge branch 'main' into autofill/pm-8207-cannot-use-keyboard-with-scribe-extension commit 154f15fa5850eba3660fba501feaea2afab44d80 Author: Victoria League <[email protected]> Date: Mon Jul 15 14:29:58 2024 -0400 [CL-285] Add default loading state to popup-page (#10040) commit bc7c6dd04ec7228cdcc4e281788f4154e1dd0d4a Author: Oscar Hinton <[email protected]> Date: Mon Jul 15 20:09:25 2024 +0200 [PM-9710] [Bootstrap] Hide file inputs when not using bootstrap (#10095) When removing boostrap it seems the hidden attribute to the file inputs stops working. This implements a "quick" fix by just adding the tw-hidden class. commit 176ac2169f8b4f7f71dc0ba915a3ba65eb64da40 Merge: ac4dbc3ef4 5df6e7aad6 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 12:26:37 2024 -0500 Merge branch 'autofill/pm-2857-inline-menu-credit-card-autofill' into autofill/pm-2858-identities-inline-menu-autofill commit 5df6e7aad69c1d3459a64c07e2334f33eaa4bbe2 Merge: 90a0070328 33c3553aa2 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 12:26:31 2024 -0500 Merge branch 'autofill/pm-8207-cannot-use-keyboard-with-scribe-extension' into autofill/pm-2857-inline-menu-credit-card-autofill commit 33c3553aa2cbe2d27a83cedb9f6d18e1572b17d2 Merge: 990c3221fc c72fae5c9a Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 12:26:24 2024 -0500 Merge branch 'main' into autofill/pm-8207-cannot-use-keyboard-with-scribe-extension commit ac4dbc3ef4826e816ad95585f5ddb724c39e3f9c Merge: 5d33725f0f 90a0070328 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 12:15:10 2024 -0500 Merge branch 'autofill/pm-2857-inline-menu-credit-card-autofill' into autofill/pm-2858-identities-inline-menu-autofill commit 90a00703287d09e7f97fff6b579920bce75ce4a6 Merge: ec64ccb4c7 990c3221fc Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 12:15:02 2024 -0500 Merge branch 'autofill/pm-8207-cannot-use-keyboard-with-scribe-extension' into autofill/pm-2857-inline-menu-credit-card-autofill commit 990c3221fc9d21fe61612bcbd0b99b949d50e0d8 Merge: e0ad86d409 e973d72b01 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 12:12:13 2024 -0500 [PM-8207] Fixing a jest tests that was missed in coverage commit c72fae5c9a40c03117ef98527fe82e5608a97cb0 Author: Bitwarden DevOps <[email protected]> Date: Mon Jul 15 11:09:09 2024 -0600 Bumped client version(s) (#10123) commit e973d72b0170a9fe40a7f4a0ac383c34bc84e2f0 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 11:57:21 2024 -0500 [PM-5189] Fix issues with inline menu rendering in iframes and SPA websites (#8431) * [PM-8027] Working through jest tests for the InlineMenuFieldQualificationService * [PM-8027] Finalization of Jest test for the implementation * [PM-5189] Fixing existing jest tests before undergoing larger scale rework of tests * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Working through jest tests for OverlayBackground * [PM-5189] Working through jest tests for OverlayBackground * [PM-5189] Reworking how we handle updating ciphers on unlock and updating reference to auth status to use observable * [PM-5189] Fixing issue with how we remove the inline menu when a field is populated * [PM-5189] Fixing issue with programmatic redirection of the inlne menu * [PM-5189] Fixing issue with programmatic redirection of the inlne menu * [PM-5189] Adjusting how we handle fade out of the inline menu element * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Implementing jest tests for the OverlayBackground * [PM-5189] Fixing a weird side issue that appears when a frame within the page triggers a reposition after the inline menu has been built * [PM-5189] Fixing a weird side issue that appears when a frame within the page triggers a reposition after the inline menu has been built * [PM-5189] Fixing a weird side issue that appears when a frame within the page triggers a reposition after the inline menu has been built * [PM-8027] Fixing a typo * [PM-8027] Incorporating a feature flag to allow us to fallback to the basic inline menu fielld qualification method if needed * [PM-8027] Incorporating a feature flag to allow us to fallback to the basic inline menu fielld qualification method if needed * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Adding jest tests for added methods in AutofillInit * [PM-5189] Refactoring implementation * [PM-5189] Implementing jest tests for the CollectAutofillContentService * [PM-5189] Implementing jest tests for the AutofillOverlayContentService * [PM-5189] Working through jest tests for the AutofillOverlayContentService * [PM-5189] Working through jest tests for the AutofillOverlayContentService * [PM-5189] Working through jest tests for the AutofillOverlayContentService * [PM-5189] Working through jest tests for the AutofillOverlayContentService * [PM-5189] Working through jest tests for the AutofillOverlayContentService * [PM-5189] Implementing jest tests for AutofillInlineMenuIframeServce * [PM-5189] Fixing a typo * [PM-5189] Fixing a typo * [PM-5189] Correcting typing information * [PM-5189] Fixing some typos * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation0 * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Implementing jest tests for AutofillInlineMenuContentService * [PM-5189] Implementing jest tests for AutofillInlineMenuContentService * [PM-5189] Implementing jest tests for AutofillInlineMenuContentService * [PM-5189] Implementing jest tests for AutofillInlineMenuContentService * [PM-5189] Implementing jest tests for AutofillInlineMenuContentService * [PM-5189] Implementing jest tests for AutofillInlineMenuContentService * [PM-5189] Implementing jest tests for AutofillInlineMenuContentService * [PM-5189] Fixing an issue found with iframe service * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Refactoring implementation * [PM-5189] Removing TODO message * [PM-5189] Increasing the time we delay the closure of the inline menu * [PM-5189] Fixing an issue with how we handle closing the inline menu after a programmtic redirection * [PM-5189] Removing unnecessary property * [PM-5189] Removing unnecessary property * [PM-5189] Fixing an issue with how scroll events trigger a reposition of the inline menu when the field is not focused; * [PM-5189] Implementing a set threshold for the maximum depth for which we are willing to calculate sub frame offsets * [PM-5189] Implementing a set threshold for the maximum depth for which we are willing to calculate sub frame offsets * [PM-5189] Implementing a set threshold for the maximum depth for which we are willing to calculate sub frame offsets * [PM-5189] Implementing a set threshold for the maximum depth for which we are willing to calculate sub frame offsets * [PM-5189] Fixing jest tests * [PM-5189] Implementing a methodology for triggering subframe updates from layout-shift * [PM-5189] Implementing a methodology for triggering subframe updates from layout-shift * [PM-8027] Fixing issue with username fields not qualifyng as a valid login field if a viewable password field is not present * [PM-8027] Fixing issue with username fields not qualifyng as a valid login field if a viewable password field is not present * [PM-8027] Fixing an issue where a field that has no form and no visible password fields should be qualified if a single password field exists in the page * [PM-8027] Fixing an issue where a field that has no form and no visible password fields should be qualified if a single password field exists in the page * [PM-5189] Implementing a methodology for triggering subframe updates from layout-shift * [PM-5189] Implementing a methodology for triggering subframe updates from layout-shift * [PM-8869] Autofill features broken on Safari * [PM-8869] Autofill features broken on Safari * [PM-5189] Working through subFrameRecalculation approach * [PM-5189] Fixing an issue found within Safari * [PM-8027] Reverting flag from a fallback flag to an enhancement feature flag * [PM-8027] Fixing jest tests * [PM-5189] Reworking how we handle updating ciphers within nested sub frames * [PM-5189] Reworking how we handle updating ciphers within nested sub frames * [PM-5189] Reworking how we handle updating ciphers within nested sub frames * [PM-5189] Reworking how we handle updating ciphers within nested sub frames * [PM-5189] Fixing issue found in Safari with how the inline menu is re-positioned * [PM-5189] Fixing issue found in Safari with how the inline menu is re-positioned * [PM-5189] Fixing issue found in Safari with how the inline menu is re-positioned * [PM-5189] Fixing jest tests * [PM-5189] Fixing jest tests * [PM-5189] Refining how we handle fading in the inline menu elements * [PM-5189] Refining how we handle fading in the inline menu elements * [PM-5189] Refining how we handle fading in the inline menu elements * [PM-5189] Reworking how we handle updating the inline menu position * [PM-5189] Reworking how we handle updating the inline menu position * [PM-5189] Reworking how we handle updating the inline menu position * [PM-5189] Reworking how we handle updating the inline menu position * [PM-5189] Reworking how we handle updating the inline menu position * [PM-5189] Reworking how we handle updating the inline menu position * [PM-5189] Reworking how we handle updating the inline menu position * [PM-5189] Working through content script port improvement * [PM-5189] Working through content script port improvement * [PM-5189] Working through content script port improvement * [PM-5189] Working through content script port improvement * [PM-5189] Working through content script port improvement * [PM-5189] Working through content script port improvement * [PM-5189] Working through content script port improvement * [PM-5189] Working through content script port improvement * [PM-5189] Working through content script port improvement * Revert "[PM-5189] Working through content script port improvement" This reverts commit 857008413f768db6595203c6af890cebca9e2cf6. * Revert "[PM-5189] Working through content script port improvement" This reverts commit f219d7107085cdf5330a0b9df41c2e966938ef3c. * Revert "[PM-5189] Working through content script port improvement" This reverts commit f389263b644adb1b7886d2b397e223f0cbd374a4. * Revert "[PM-5189] Working through content script port improvement" This reverts commit 8a48e576e13e94b8003d57e610356af73e378a75. * Revert "[PM-5189] Working through content script port improvement" This reverts commit e30a1ebc5d2f36b8fbf3e92b13a6f7426e366e44. * Revert "[PM-5189] Working through content script port improvement" This reverts commit da357f46b3e8d062a37f420a47cadaddb35eecc2. * [PM-5189] Reverting content script port rework * [PM-5189] Fixing jest tests for AutofillOverlayContentService * [PM-5189] Adding documentation for the AutofillOverlayContentService * [PM-5189] Working through jest tests for OverlayBackground and refining repositioning delays * [PM-5189] Working through jest tests for OverlayBackground and refining repositioning delays * [PM-5189] Throttling how often sub frame calculations can be triggered from the focus in listener * [PM-5189] Finalizing jest tests for AutofillOverlayContentService * [PM-5189] Finalizing jest tests for AutofillOverlayContentService * [PM-5189] Finalizing jest tests for AutofillOverlayContentService * [PM-5189] Removing custom debounce method that is unused * [PM-5189] Removing custom debounce method that is unused * [PM-2857] Reworking how we handle invalidating cache when a tab chagne has occurred * [PM-5189] Fixing issues found within code review behind how we position elements * [PM-5189] Fixing issues found within code review behind how we position elements * [PM-5189] Fixing issues found within code review behind how we position elements * [PM-5189] Fixing issues found within code review behind how we position elements * [PM-5189] Fixing issues found within code review behind how we position elements * [PM-5189] Fixing issues found within code review behind how we position elements * [PM-5189] Adding jest tests for OverlayBackground methods * [PM-5189] Adding jest tests for OverlayContentService methods * [PM-5189] Working through further issues on positioning of inline menu * [PM-5189] Working through further issues on positioning of inline menu * [PM-5189] Working through further issues on positioning of inline menu * [PM-5189] Working through further issues on positioning of inline menu * [PM-5189] Working through jest tests for OverlayBackground and refining repositioning delays * [PM-5189] Working through jest tests for OverlayBackground and refining repositioning delays * [PM-5189] Working through jest tests for OverlayBackground and refining repositioning delays * [PM-5189] Working through jest tests for OverlayBackground and refining repositioning delays * [PM-5189] Working through jest tests for OverlayBackground and refining repositioning delays * [PM-5189] Fixing an issue found when switching between open windows * [PM-5189] Fixing an issue found when switching between open windows * [PM-5189] Removing throttle from resize listeners within the content script * [PM-5189] Removing throttle from resize listeners within the content script * [PM-5189] Fixing issue within Safari relating to repositioning elements from outer frame * [PM-5189] Fixing issue within Safari relating to repositioning elements from outer frame * [PM-5189] Fixing issue within Safari relating to repositioning elements from outer frame * [PM-5189] Adding some documentation and adjust jest test for util method * [PM-5189] Reverting naming structure for OverlayBackground method * [PM-5189] Fixing a missed promise reference within OverlayBackground * [PM-5189] Removing throttle from resize listeners within the content script * Revert "[PM-5189] Removing throttle from resize listeners within the content script" This reverts commit 62cf0f8f24dcccd21883f07b78855b26660cccb8. * [PM-5189] Re-adding throttle and reducing delay * [PM-5189] Fixing an issue with onButton click settings not being respected when a reposition event occurs * [PM-5189] Adding a missing test to OverlayBackground * [PM-5189] Fixing an issue where we trigger a blur event when the inline menu is hovered, but the page takes focus away * [PM-9342] Inline menu does not show on username field for a form that has a password field with an invalid autocomplete value * [PM-9342] Incorporating logic to handle multiple autocomplete values within a captured set of page details * [PM-9342] Incorporating logic to handle multiple autocomplete values within a captured set of page details * [PM-9342] Changing logic for how we identify new password fields to reflect a more assertive qualification * [PM-9342] Adding feedback from code review * [PM-5189] Fixing an issue where the port key for an inline menu element could potentially be undefined if the window focus changes too quickly * [PM-5189] Fixing an issue where we can potentially show the inline menu incorrectly after a user switches account * [PM-5189] Fixing an issue where we can potentially show the inline menu incorrectly after a user switches account * [PM-5189] Fixing an issue where we can potentially show the inline menu incorrectly after a user switches account * [PM-5189] Fixing an issue where we can potentially show the inline menu incorrectly after a user switches account * [PM-9267] Implement feature flag for inline menu re-architecture (#9845) * [PM-9267] Implement Feature Flag for Inline Menu Re-Architecture * [PM-9267] Incorporating legacy OverlayBackground implementation * [PM-9267] Incorporating legacy overlay content scripts * [PM-9267] Incorporating legacy overlay content scripts * [PM-9267] Incorporating legacy overlay content scripts * [PM-9267] Incorporating legacy overlay content scripts * [PM-9267] Finalizing feature flag implementation * [PM-9267] Finalizing feature flag implementation * [PM-9267] Finalizing feature flag implementation * [PM-9267] Finalizing feature flag implementation * [PM-9267] Finalizing feature flag implementation * [PM-9267] Finalizing feature flag implementation * [PM-9267] Finalizing feature flag implementation * [PM-9267] Finalizing feature flag implementation * [PM-9267] Adjusting naming convention for page files * [PM-9267] Adjusting naming convention for page files * [PM-5189] Fixing an issue where we can potentially show the inline menu incorrectly after a user switches account * PM-4950 - Fix hint and verify delete components that had the data in the wrong place (#9877) * PM-4661: Add passkey.username as item.username (#9756) * Add incoming passkey.username as item.username * Driveby fix, was sending wrong username * added username to new-cipher too * Guarded the if-block * Update apps/browser/src/vault/popup/components/vault/add-edit.component.ts Co-authored-by: Justin Baur <[email protected]> * Fixed broken test * fixed username on existing ciphers --------- Co-authored-by: Justin Baur <[email protected]> * PM-4878: Add passkey information to items when signing in (#9835) * Added username to subtitle * Added subName to cipher * Moved subName to component * Update apps/browser/src/vault/popup/components/fido2/fido2-cipher-row.component.ts Co-authored-by: SmithThe4th <[email protected]> * Fixed double code and added comment * Added changeDetection: ChangeDetectionStrategy.OnPush as per review --------- Co-authored-by: SmithThe4th <[email protected]> * [AC-2791] Members page - finish component library refactors (#9727) * Replace PlatformUtilsService with ToastService * Remove unneeded templates * Implement table filtering function * Move member-only methods from base class to subclass * Move utility functions inside new MemberTableDataSource * Rename PeopleComponent to MembersComponent * [deps] Platform: Update angular-cli monorepo to v16.2.14 (#9380) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [PM-8789] Move desktop_native into subcrate (#9682) * Move desktop_native into subcrate * Add publish = false to crates * [PM-6394] remove policy evaluator cache (#9807) * [PM-9364] Copy for Aggregate auto-scaling invoices for Teams and Enterprise customers (#9875) * Change the seat adjustment message * Move changes from en_GB file to en file * revert changes in en_GB file * Add feature flag to the change * use user verification as a part of key rotation (#9722) * Add the ability for custom validation logic to be injected into `UserVerificationDialogComponent` (#8770) * Introduce `verificationType` * Update template to use `verificationType` * Implement a path for `verificationType = 'custom'` * Delete `clientSideOnlyVerification` * Update `EnrollMasterPasswordResetComponent` to include a server-side hash check * Better describe the custom scenerio through comments * Add an example of the custom verficiation scenerio * Move execution of verification function into try/catch * Migrate existing uses of `clientSideOnlyVerification` * Use generic type option instead of casting * Change "given" to "determined" in a comment * Restructure the `org-redirect` guard to be Angular 17+ compliant (#9552) * Document the `org-redirect` guard in code * Make assertions about the way the `org-redirect` guard should behave * Restructure the `org-redirect` guard to be Angular 17+ compliant * Convert data parameter to function parameter * Convert a data parameter to a function parameter that was missed * Pass redirect function to default organization route * don't initialize kdf with validators, do it on first set (#9754) * add testids for attachments (#9892) * Bug fix - error toast in 2fa (#9623) * Bug fix - error toast in 2fa * Bug fix - Yubikey code obscured * 2FA error fix * Restructure the `is-paid-org` guard to be Angular 17+ compliant (#9598) * Document that `is-paid-org` guard in code * Remove unused `MessagingService` dependency * Make assertions about the way the is-paid-org guard should behave * Restructure the `is-paid-org` guard to be Angular 17+ compliant * Random commit to get the build job moving * Undo previous commit * Bumped client version(s) (#9895) * [PM-9344] Clarify accepted user state (#9861) * Prefer `Needs confirmation` to `Accepted` display status This emphasizes that action is still required to complete setup. * Remove unused message * Bumped client version(s) (#9906) * Revert "Bumped client version(s) (#9906)" (#9907) This reverts commit 78c28297938eda53e7731fdf9f63d7baa7068d0d. * fix duo subscriptions and org vs individual duo setup (#9859) * [PM-5024] Migrate tax-info component (#9872) * Changes for the tax info migration * Return for invalid formgroup * Restructure the `org-permissions` guard to be Angular 17+ compliant (#9631) * Document the `org-permissions` guard in code * Restructure the `org-permissions` guard to be Angular 17+ compliant * Update the `org-permissions` guard to use `ToastService` * Simplify callback function sigantures * Remove unused test object * Fix updated route from merge * Restructure the `provider-permissions` guard to be Angular 17+ compliant (#9609) * Document the `provider-permissions` guard in code * Restructure the `provider-permissions` guard to be Angular 17+ compliant * [deps] Platform: Update @types/argon2-browser to v1.18.4 (#8180) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bumped client version(s) (#9914) * [PM-7162] Cipher Form - Item Details (#9758) * [PM-7162] Fix weird angular error regarding disabled component bit-select * [PM-7162] Introduce CipherFormConfigService and related types * [PM-7162] Introduce CipherFormService * [PM-7162] Introduce the Item Details section component and the CipherFormContainer interface * [PM-7162] Introduce the CipherForm component * [PM-7162] Add strongly typed QueryParams to the add-edit-v2.component * [PM-7162] Export CipherForm from Vault Lib * [PM-7162] Use the CipherForm in Browser AddEditV2 * [PM-7162] Introduce CipherForm storybook * [PM-7162] Remove VaultPopupListFilterService dependency from NewItemDropDownV2 component * [PM-7162] Add support for content projection of attachment button * [PM-7162] Fix typo * [PM-7162] Cipher form service cleanup * [PM-7162] Move readonly collection notice to bit-hint * [PM-7162] Refactor CipherFormConfig type to enforce required properties with Typescript * [PM-7162] Fix storybook after config changes * [PM-7162] Use new add-edit component for clone route * [deps]: Update @yao-pkg/pkg to ^5.12.0 (#9820) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Autosync the updated translations (#9922) Co-authored-by: bitwarden-devops-bot <[email protected]> * Autosync the updated translations (#9923) Co-authored-by: bitwarden-devops-bot <[email protected]> * Autosync the updated translations (#9924) Co-authored-by: bitwarden-devops-bot <[email protected]> * [AC-2830] Unable to create a free organization (#9917) * Resolve the issue free org creation * Check that the taxForm is touched * [PM-7162] Fix broken getter when original cipher is null (#9927) * [PM-8525] Edit Card (#9901) * initial add of card details section * add card number * update card brand when the card number changes * add year and month fields * add security code field * hide number and security code by default * add `id` for all form fields * update select options to match existing options * make year input numerical * only display card details for card ciphers * use style to set input height * handle numerical values for year * update heading when a brand is available * remove unused ref * use cardview types for the form * fix numerical input type * disable card details when in partial-edit mode * remove hardcoded height * update types for formBuilder * [PM-9440] Fix: handle undefined value in migration 66 (#9908) * fix: handle undefined value in migration 66 * fix: the if-statement was typo * Rename "encryptionAlgorithm" to "hashAlgorithmForEncryption" for clarity (#9891) * [PM-7972] Account switching integration with "remember email" functionality (#9750) * add account switching logic to login email service * enforce boolean and fix desktop account switcher order * [PM-9442] Add tests for undefined state values and proper emulation of ElectronStorageService in tests (#9910) * fix: handle undefined value in migration 66 * fix: the if-statement was typo * feat: duplicate error behavior in fake storage service * feat: fix all migrations that were setting undefined values * feat: add test for disabled fingrint in migration 66 * fix: default single user state saving undefined value to state * revert: awaiting floating promise gonna fix this in a separate PR * Revert "feat: fix all migrations that were setting undefined values" This reverts commit 034713256cee9a8e164295c88157fe33d8372c81. * feat: automatically convert save to remove * Revert "fix: default single user state saving undefined value to state" This reverts commit 6c36da6ba52f6886d0de2b502b3aaff7f122c3a7. * [AC-2805] Consolidated Billing UI Updates (#9893) * Add empty state for invoices * Make cards on create client dialog tabbable * Add space in $ / month per member * Mute text, remove (Monthly) and right align menu on clients table * Made used seats account for all users and fixed column sort for used/remaining * Resize pricing cards * Rename assignedSeats to occupiedSeats * [PM-9460][deps] Tools: Update electron to v31 (#9921) * [deps] Tools: Update electron to v31 * Bump version in electron-builder --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel James Smith <[email protected]> * [AC-1452] Restrict access to 'Organization Info' and 'Two-Step Login' settings pages with a permission check (#9483) * Guard Organization Info route - Owners only * Guard TwoFactor route - Owners only and Organization must be able to use 2FA * Update guards to use function syntax --------- Co-authored-by: Addison Beck <[email protected]> * [PM-9437] Use CollectionAccessDetailsResponse type now that is always the type returned from the API (#9951) * Add required env variables to desktop native build script (#9869) * [AC-2676] Remove paging logic from GroupsComponent (#9705) * remove infinite scroll, use virtual scroll instead * use TableDataSource for search * allow sorting by name * replacing PlatformUtilsService.showToast with ToastService * misc FIXMEs * [PM-9441] Catch and log exceptions during migration (#9905) * feat: catch and log exceptions during migration * Revert "feat: catch and log exceptions during migration" This reverts commit d68733b7e58120298974b350e496bb3e0c9af0d2. * feat: use log service to log migration errors * Autosync the updated translations (#9972) Co-authored-by: bitwarden-devops-bot <[email protected]> * Autosync the updated translations (#9973) Co-authored-by: bitwarden-devops-bot <[email protected]> * Updated codeowners for new design system team (#9913) * Updated codeowners for new design system team. * Moved Angular and Bootstrap dependencies * Moved additional dependencies. * Updated ownership Co-authored-by: Will Martin <[email protected]> --------- Co-authored-by: Will Martin <[email protected]> * [SM-1016] Fix new access token dialog (#9918) * swap to bit-dialog title & subtitle * remove dialogRef.disableClose & use toastService * Add shared two-factor-options component (#9767) * Communicate the upcoming client vault privacy changes to MSPs (#9994) * Add a banner notification to the provider portal * Feature flag the banner * Move banner copy to messages.json * Allow for dismissing the banner * Auth/PM-7321 - Registration with Email Verification - Registration Finish Component Implementation (#9653) * PM-7321 - Temp add input password * PM-7321 - update input password based on latest PR changes to test. * PM-7321 - Progress on testing input password component + RegistrationFinishComponent checks * PM-7321 - more progress on registration finish. * PM-7321 - Wire up RegistrationFinishRequest model + AccountApiService abstraction + implementation changes for new method. * PM-7321 - WIP Registration Finish - wiring up request building and API call on submit. * PM-7321 - WIP registratin finish * PM-7321 - WIP on creating registration-finish service + web override to add org invite handling * PM-7321 - (1) Move web-registration-finish svc to web (2) Wire up exports (3) wire up RegistrationFinishComponent to call registration finish service * PM-7321 - Get CLI building * PM-7321 - Move all finish registration service and content to registration-finish feature folder. * PM-7321 - Fix RegistrationFinishService config * PM-7321 - RegistrationFinishComponent- handlePasswordFormSubmit - error handling WIP * PM-7321 - InputPasswordComp - Update to accept masterPasswordPolicyOptions as input instead of retrieving it as parent components in different scenarios will need to retrieve the policies differently (e.g., orgInvite token in registration vs direct call via org id post SSO on set password) * PM-7321 - Registration Finish - Add web specific logic for retrieving master password policies and passing them into the input password component. * PM-7321 - Registration Start - Send email via query param to registration finish page so it can create masterKey * PM-7321 - InputPassword comp - (1) Add loading input (2) Add email validation to submit logic. * PM-7321 - Registration Finish - Add submitting state and pass into input password so that the rest of the registration process keeps the child form disabled. * PM-7321 - Registration Finish - use validation service for error handling. * PM-7321 - All register routes must be dynamic and change if the feature flag changes. * PM-7321 - Test registration finish services. * PM-7321 - RegisterRouteService - Add comment documenting why the service exists. * PM-7321 - Add missing input password translations to browser & desktop * PM-7321 - WebRegistrationFinishSvc - apply PR feedback * [deps] Autofill: Update rimraf to v5.0.8 (#10008) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [PM-9318] Fix username on protonpass import (#9889) * Fix username field used for ProtonPass import ProtonPass has changed their export format and userName is not itemEmail * Import additional field itemUsername --------- Co-authored-by: Daniel James Smith <[email protected]> * [PM-8943] Update QRious script initialization in Authenticator two-factor provider (#9926) * create onload() for qrious as well as error messaging if QR code cannot be displayed * button and message updates and formpromise removal * load QR script async * rename and reorder methods * Delete Unused Bits of StateService (#9858) * Delete Unused Bits of StateService * Fix Tests * remove getBgService for auth request service (#10020) --------- Co-authored-by: Jared Snider <[email protected]> Co-authored-by: Anders Åberg <[email protected]> Co-authored-by: Justin Baur <[email protected]> Co-authored-by: SmithThe4th <[email protected]> Co-authored-by: Thomas Rittson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel García <[email protected]> Co-authored-by: ✨ Audrey ✨ <[email protected]> Co-authored-by: cyprain-okeke <[email protected]> Co-authored-by: Jake Fink <[email protected]> Co-authored-by: Addison Beck <[email protected]> Co-authored-by: Nick Krantz <[email protected]> Co-authored-by: vinith-kovan <[email protected]> Co-authored-by: Bitwarden DevOps <[email protected]> Co-authored-by: Matt Gibson <[email protected]> Co-authored-by: Opeyemi <[email protected]> Co-authored-by: Shane Melton <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andreas Coroiu <[email protected]> Co-authored-by: Bernd Schoolmann <[email protected]> Co-authored-by: Alex Morask <[email protected]> Co-authored-by: Daniel James Smith <[email protected]> Co-authored-by: Rui Tomé <[email protected]> Co-authored-by: Addison Beck <[email protected]> Co-authored-by: Todd Martin <[email protected]> Co-authored-by: Will Martin <[email protected]> Co-authored-by: Thomas Avery <[email protected]> Co-authored-by: Daniel James Smith <[email protected]> Co-authored-by: Ike <[email protected]> --------- Co-authored-by: Jared Snider <[email protected]> Co-authored-by: Anders Åberg <[email protected]> Co-authored-by: Justin Baur <[email protected]> Co-authored-by: SmithThe4th <[email protected]> Co-authored-by: Thomas Rittson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel García <[email protected]> Co-authored-by: ✨ Audrey ✨ <[email protected]> Co-authored-by: cyprain-okeke <[email protected]> Co-authored-by: Jake Fink <[email protected]> Co-authored-by: Addison Beck <[email protected]> Co-authored-by: Nick Krantz <[email protected]> Co-authored-by: vinith-kovan <[email protected]> Co-authored-by: Bitwarden DevOps <[email protected]> Co-authored-by: Matt Gibson <[email protected]> Co-authored-by: Opeyemi <[email protected]> Co-authored-by: Shane Melton <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andreas Coroiu <[email protected]> Co-authored-by: Bernd Schoolmann <[email protected]> Co-authored-by: Alex Morask <[email protected]> Co-authored-by: Daniel James Smith <[email protected]> Co-authored-by: Rui Tomé <[email protected]> Co-authored-by: Addison Beck <[email protected]> Co-authored-by: Todd Martin <[email protected]> Co-authored-by: Will Martin <[email protected]> Co-authored-by: Thomas Avery <[email protected]> Co-authored-by: Daniel James Smith <[email protected]> Co-authored-by: Ike <[email protected]> commit 7ed143dc62d14ee0711a87bf4a7b5baca7cec012 Author: Bitwarden DevOps <[email protected]> Date: Mon Jul 15 10:51:19 2024 -0600 Bumped client version(s) (#10122) commit d2685e1bc5c8c55dac97da352cfe86d0d65b6258 Author: Ike <[email protected]> Date: Mon Jul 15 09:04:15 2024 -0700 [PM-9618] Show toast when `AuthUrl` is `null` (#10108) * Added toast message if AuthUrl is null * added toast to desktop and browser * fixed tests commit e7b50e790ae2b684e801b452d1f0f235f23a02f1 Author: Alex Morask <[email protected]> Date: Mon Jul 15 11:56:11 2024 -0400 [AC-2828] Add provider portal members page behind FF (#9949) * Add provider portal members page behind a FF * Fix reinvite issue * Import scrolling module * Add deprecations to old classes * Move members.component init to constructor * Rename new-base.people.component to base.members.component * Hide bulk reinvite when no users can be re-invited on AC members page * Rename events() to openEventsDialog() * Fix return type for members component getUsers() * Make table headers sortable * Extract row height class to ts file * Convert open methods to static methods for bulk dialogs * Rename and refactor member-dialog.component * Prevent event emission for searchControl and set filter in members component constructor * use featureFlaggedRoute rather than using FF in components * Add BaseBulkConfirmComponent for use in both web and bit-web * Add BaseBulkRemoveComponent for use in both web and bit-web * Thomas' feedback on base confirm/remove * Remaining feedback commit 5d33725f0facd411959e1aca949447fdfbb55cc0 Merge: 0e86b063be ec64ccb4c7 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:49:04 2024 -0500 Merge branch 'autofill/pm-2857-inline-menu-credit-card-autofill' into autofill/pm-2858-identities-inline-menu-autofill commit ec64ccb4c76202ff371c42688a1fe1327b68f753 Merge: d01f8b5f03 e0ad86d409 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:48:55 2024 -0500 Merge branch 'autofill/pm-8207-cannot-use-keyboard-with-scribe-extension' into autofill/pm-2857-inline-menu-credit-card-autofill commit e0ad86d4091140c727e858cdce3eb4c9b8a9323c Merge: b56c3f53f5 564f1c5d12 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:48:49 2024 -0500 Merge branch 'autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes' into autofill/pm-8207-cannot-use-keyboard-with-scribe-extension commit 4edbd65faf46482cb095b5e10fc652548a03e467 Author: Jordan Aasen <[email protected]> Date: Mon Jul 15 08:47:30 2024 -0700 [PM-3197] "Pay with PayPal" button moves on screen after loading (#10083) * hide duplicate iframe * add comment * Moved braintree styling to plugins.scss * Moved next to other braintree-sheet --------- Co-authored-by: Conner Turnbull <[email protected]> commit 564f1c5d1226812fc66cb0cc331803ec87910382 Merge: fddaab92d3 974162b1a4 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:46:02 2024 -0500 [PM-5189] Merging changes from main into branch and fixing merge conflicts commit 974162b1a4a6a0013a95ed1046d0157b3736fe3d Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:32:30 2024 -0500 [PM-6426] Create TaskSchedulerService and update long lived timeouts in the extension to leverage the new service (#8566) * [PM-6426] Create TaskSchedulerService and update usage of long lived timeouts * [PM-6426] Implementing nextSync timeout using TaskScheduler * [PM-6426] Implementing systemClearClipboard using TaskScheduler * [PM-6426] Fixing race condition with setting/unsetting active alarms * [PM-6426] Implementing clear clipboard call on generatePasswordToClipboard with the TaskSchedulerService * [PM-6426] Implementing abortTimeout for Fido2ClientService using TaskSchedulerService * [PM-6426] Implementing reconnect timer timeout for NotificationService using the TaskSchedulerService * [PM-6426] Implementing reconnect timer timeout for NotificationService using the TaskSchedulerService * [PM-6426] Implementing sessionTimeout for LoginStrategyService using TaskSchedulerService * [PM-6426] Implementing eventUploadInterval using TaskScheduler * [PM-6426] Adding jest tests for the base TaskSchedulerService class * [PM-6426] Updating jest tests for GeneratePasswordToClipboardCommand * [PM-6426] Setting up the full sync process as an interval rather than a timeout * [PM-6426] Renaming the scheduleNextSync alarm name * [PM-6426] Fixing dependency references in services.module.ts * [PM-6426] Adding jest tests for added BrowserApi methods * [PM-6426] Refactoring small detail for how we identify the clear clipboard timeout in SystemService * [PM-6426] Ensuring that we await clearing an established scheduled task for the notification service * [PM-6426] Changing the name of the state definition for the TaskScheduler * [PM-6426] Implementing jest tests for the BrowserTaskSchedulerService * [PM-6426] Implementing jest tests for the BrowserTaskSchedulerService * [PM-6426] Adding jest tests for the base TaskSchedulerService class * [PM-6426] Finalizing jest tests for BrowserTaskScheduler class * [PM-6426] Finalizing documentation on BrowserTaskSchedulerService * [PM-6426] Fixing jest test for LoginStrategyService * [PM-6426] Implementing compatibility for the browser.alarms api * [PM-6426] Fixing how we check for the browser alarms api * [PM-6426] Adding jest tests to the BrowserApi implementation * [PM-6426] Aligning the implementation with our code guidelines for Angular components * [PM-6426] Fixing jest tests and lint errors * [PM-6426] Moving alarms api calls out of BrowserApi and structuring them within the BrowserTaskSchedulerService * [PM-6426] Reworking implementation to register handlers separately from the call to those handlers * [PM-6426] Adjusting how we register the fullSync scheduled task * [PM-6426] Implementing approach for incorporating the user UUID when setting task handlers * [PM-6426] Attempting to re-work implementation to facilitate userId-spcific alarms * [PM-6426] Refactoring smaller details of the implementation * [PM-6426] Working through the details of the implementation and setting up final refinments * [PM-6426] Fixing some issues surrounding duplicate alarms triggering * [PM-6426] Adjusting name for generate password to clipboard command task name * [PM-6426] Fixing generate password to clipboard command jest tests * [PM-6426] Working through jest tests and implementing a method to guard against setting a task without having a registered callback * [PM-6426] Working through jest tests and implementing a method to guard against setting a task without having a registered callback * [PM-6426] Implementing methodology for having a fallback to setTimeout if the browser context is lost in some manner * [PM-6426] Working through jest tests * [PM-6426] Working through jest tests * [PM-6426] Working through jest tests * [PM-6426] Working through jest tests * [PM-6426] Finalizing stepped setInterval implementation * [PM-6426] Implementing Jest tests for DefaultTaskSchedulerService * [PM-6426] Adjusting jest tests * [PM-6426] Adjusting jest tests * [PM-6426] Adjusting jest tests * [PM-6426] Fixing issues identified in code review * [PM-6426] Fixing issues identified in code review * [PM-6426] Removing user-based alarms and fixing an issue found with setting steppedd alarm interavals * [PM-6426] Removing user-based alarms and fixing an issue found with setting steppedd alarm interavals * [PM-6426] Fixing issue with typing information on a test * [PM-6426] Using the getUpperBoundDelayInMinutes method to handle setting stepped alarms and setTimeout fallbacks * [PM-6426] Removing the potential for the TaskScheduler to be optional * [PM-6426] Reworking implementation to leverage subscription based deregistration of alarms * [PM-6426] Fixing jest tests * [PM-6426] Implementing foreground and background task scheduler services to avoid duplication of task scheudlers and to have the background setup as a fallback to the poopup tasks * [PM-6426] Implementing foreground and background task scheduler services to avoid duplication of task scheudlers and to have the background setup as a fallback to the poopup tasks * [PM-6426] Merging main into branch * [PM-6426] Fixing issues with the CLI Service Container implementation * [PM-6426] Reworking swallowed promises to contain a catch statement allow us to debug potential issues with registrations of alarms * [PM-6426] Adding jest tests to the ForegroundTaskSchedulerService and the BackgroundTaskSchedulerService * [PM-6426] Adding jest tests to the ForegroundTaskSchedulerService and the BackgroundTaskSchedulerService * [PM-6426] Adding jest tests to the ForegroundTaskSchedulerService and the BackgroundTaskSchedulerService * [PM-6426] Adding jest tests to the ForegroundTaskSchedulerService and the BackgroundTaskSchedulerService * [PM-6426] Adjusting implementation based on code review feedback * [PM-6426] Reworking file structure * [PM-6426] Reworking file structure * [PM-6426] Adding comments to provide clarity on how the login strategy cache experiation state is used * [PM-6426] Catching and logging erorrs that appear from methods that return a promise within VaultTimeoutService commit 0e86b063be7ed8596d114c02f9eb73009a69ce30 Merge: 3e717f18e4 d01f8b5f03 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:13:33 2024 -0500 Merge branch 'autofill/pm-2857-inline-menu-credit-card-autofill' into autofill/pm-2858-identities-inline-menu-autofill commit d01f8b5f031b00f479e81fff94b368af1c6f2cbf Merge: 4a446ee9fb b56c3f53f5 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:13:14 2024 -0500 Merge branch 'autofill/pm-8207-cannot-use-keyboard-with-scribe-extension' into autofill/pm-2857-inline-menu-credit-card-autofill commit b56c3f53f51054e2fe76a0a5b5f4e323f644afc6 Merge: 5dc168a51b fddaab92d3 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:13:06 2024 -0500 Merge branch 'autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes' into autofill/pm-8207-cannot-use-keyboard-with-scribe-extension commit fddaab92d3468dc86e40d2d986da59f281ab5ffd Merge: 53f7d4db9e 5fcf4bbd10 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 10:12:47 2024 -0500 Merge branch 'main' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes commit 5fcf4bbd10b4d356f24f40d7c4aca450b10f5aab Author: Justin Baur <[email protected]> Date: Mon Jul 15 10:41:10 2024 -0400 [PM-8979] Check that user is authed before getting user config (#10031) * Check that user is authed before getting user config * Accept PR Suggestion Co-authored-by: Andreas Coroiu <[email protected]> * Use Strict Equal --------- Co-authored-by: Andreas Coroiu <[email protected]> commit 5a46c7d5cc27ace85c93b371e4327012386afae3 Author: Bernd Schoolmann <[email protected]> Date: Mon Jul 15 15:59:39 2024 +0200 [PM-7084] 4/6: Introduce shared email two-factor component (#9770) * Add shared email two-factor component * Update apps/browser/src/auth/popup/two-factor-auth-email.component.ts Co-authored-by: Jake Fink <[email protected]> --------- Co-authored-by: Jake Fink <[email protected]> commit 53f7d4db9e0e1195fdef02d1433f01bc0ffb1870 Merge: d305210410 a1667e5603 Author: Cesar Gonzalez <[email protected]> Date: Mon Jul 15 08:56:26 2024 -0500 Merge branch 'main' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes commit a1667e56030f3740636536aa25f513685bbae2cf Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 11:00:21 2024 +0000 Autosync the updated translations (#10118) Co-authored-by: bitwarden-devops-bot <[email protected]> commit 5969f24254df79709761b9646bd909b5013da53a Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 12:55:34 2024 +0200 Autosync the updated translations (#10115) Co-authored-by: bitwarden-devops-bot <[email protected]> commit 0a04a47c753605b15ffe8e0ca3d16b5f3df2bc96 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 12:52:31 2024 +0200 Autosync the updated translations (#10117) Co-authored-by: bitwarden-devops-bot <[email protected]> commit fb311bfb4b9beca787faa884434a3410513fe733 Author: Jordan Aasen <[email protected]> Date: Mon Jul 15 03:26:11 2024 -0700 [PM-4964] migrate exposed passwords report components (#9952) * WIP - migrate exposed passwords report components * lint fix * migrate components in reports * migrate breach and unsecured websites reports * undo change routing * revert changes to reports * revert changes * fix icon and padding in exposed passwords report * fix icon and padding in exposed passwords report * fix exposed passwords report cipher state * [PM-4965] Migrate inactive two factor report (#10043) * migrate inactive two factor report * fix icon and padding in inactive two factor report * [PM-4967] Migrate reused passwords report components (#10044) * migrate components in reused passwords report * fix icon and padding in reused passwords report * [PM-4969] Migrate weak passwords report components (#10048) * migrate weak passwords report component * migrate weak passwords report component * Revert "migrate weak passwords report component" This reverts commit 0e453aafc154fee48f37bb22a7f24cdf2847a43c. * Revert "migrate weak passwords report component" This reverts commit e8e9b01997ce453e9292b7f49ccc8ac81bab690d. * Revert "Revert "migrate weak passwords report component"" This reverts commit 8cd2421cb0107cf579f3a83acb97f9f3dbf5e5e6. * fix padding and icon size in weak passwords report --------- Co-authored-by: jordan-bite <[email protected]> commit 739cd8d25b4a5218d0284e64f1844fb143114ec9 Author: kwiateusz <[email protected]> Date: Mon Jul 15 12:24:53 2024 +0200 …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.