Expose saving a field in a contact or a paper for inline menu #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
commented
Sep 6, 2024
| const cipher = this.inlineMenuCiphers.get(inlineMenuCipherId); | ||
|
|
||
| const { data: contact } = (await client.query(Q(CONTACTS_DOCTYPE).getById(cipher.id), { | ||
| executeFromStore: true, |
There was a problem hiding this comment.
Not sure about the executeFromStore here. Maybe we should get the fresh data no ?
zatteo
force-pushed
the
feat/save-field-to-cozy-data
branch
2 times, most recently
from
01e58d7
to
bb82b49
Compare
We use more and more lodash to manage data with path. It is working until now because it is present as a sub deps from Angular. Let's add it as an explicit deps to avoid future issues if they remove it.
zatteo
force-pushed
the
feat/save-field-to-cozy-data
branch
from
bb82b49
to
5b037a9
Compare
Merkur39
approved these changes
Sep 11, 2024
Comment on lines
+163
to
+170
| // Add contact | ||
| // const fileCollection = client.collection('io.cozy.files') | ||
| // const references = [{ | ||
| // _id: contact._id, | ||
| // _type: 'io.cozy.contacts' | ||
| // }] | ||
|
|
||
| // await fileCollection.addReferencedBy(fileCreated, references) |
There was a problem hiding this comment.
Exactement, il y a encore quelques questionnements sur cette partie, mais "le reste marche"
zatteo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.