Fixes for autofill and translations #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If paper.cozyMetadata.sourceAccountIdentifier and contactEmail were undefined, it was considered as a paper from the contact even if it has no sense. I added multiple tests to improve the function safety.
demande-logement-social.gouv.fr On demande-logement-social.gouv.fr, we need to be able to autofill the tax revenue for the two last years. Previously, the two tax revenue fields had the target date like "2022" in the "tag" field. But the form has changed and now, there is no way to know the date of the tax revenue we want. For the moment we hardcode the year targeted by each field with the field ID.
zatteo
force-pushed
the
feat/new-style
branch
from
16d447d
to
5710fd9
Compare
Merkur39
reviewed
Sep 18, 2024
Comment on lines
+393
to
+400
| // Special case for demande-logement-social.gouv.fr | ||
| if (field.htmlID.includes("montantMoins1")) { | ||
| return 2023; | ||
| } | ||
| if (field.htmlID.includes("montantMoins2")) { | ||
| return 2022; | ||
| } | ||
|
|
There was a problem hiding this comment.
@zatteo Est-ce qu'on ne préfère pas quelque chose comme ça ?
Suggested change
| // Special case for demande-logement-social.gouv.fr | |
| if (field.htmlID.includes("montantMoins1")) { | |
| return 2023; | |
| } | |
| if (field.htmlID.includes("montantMoins2")) { | |
| return 2022; | |
| } | |
| // Special case for demande-logement-social.gouv.fr | |
| if (field.htmlID.includes("montantMoins1")) { | |
| return new Date().getFullYear() - 1; | |
| } | |
| if (field.htmlID.includes("montantMoins2")) { | |
| return new Date().getFullYear() - 2; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.