feat: Create inline-menu with address contact fields #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of ciphers with contacts must always be in the same order, otherwise opening the inline-menu after an autofill will result in the wrong contact being selected.
Merkur39
force-pushed
the
feat/address-edition
branch
from
2a983e7
to
4ee2f97
Compare
zatteo
reviewed
Sep 24, 2024
zatteo
approved these changes
Sep 24, 2024
zatteo
reviewed
Sep 24, 2024
apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts
Outdated
Show resolved
Hide resolved
...on all address fields.
In the case of address editing, we need more height.
Merkur39
force-pushed
the
feat/address-edition
branch
from
4ee2f97
to
09fcba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR ajoute le formulaire de création d'adresse dans l'inline-menu.