Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogenise methods naming and arguments orders #163

Open
Ldoppea opened this issue Sep 9, 2021 · 0 comments
Open

Homogenise methods naming and arguments orders #163

Ldoppea opened this issue Sep 9, 2021 · 0 comments

Comments

@Ldoppea
Copy link
Member

Ldoppea commented Sep 9, 2021

Methods arguments orders may be swapped between methods calls.

See https://github.com/cozy/cozy-keys-lib/blob/master/src/WebVaultClient.js#L357-L382

computeNewHashAndKeys and bitwardenChangePassword have reversed order for kdf and kdfIteration

Also this file use password wording while other apps mays use passphrase (i.e: cozy-pass-web and cozy-settings).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ldoppea