fix: call cryptoService.makeKey directly form computeMasterKey
#162
Conversation
Previous version introduced unnecessary complexity as `kdfIterations` and `kdf` were ignored by `authService.makePreloginKey()` Also the `iterations` handling did not work correctly as the ternary operator was reversed As the only value of `authService.makePreloginKey()` is to query `kdfIterations` and `kdf` and because we never call `computeMasterKey()` with those values unset, then we call `cryptoService.makeKey()` directly
|
Note that this method is used only from Therefore I'm tempted to change the method signature as |
|
You can create a BC with a message describing how to handle the breaking change. This BC is minor ;) |
Do you mean in a new changelog.md file? or in a comment on the code? |
We're in a cozy-libs, we don't handle changelog.md, github release based on our commit's messages does that for us. https://github.com/cozy/cozy-guidelines#breaking-change is enough ;) |
|
🎉 This PR is included in version 3.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Some old Cozy may not have any `io.cozy.settings.bitwarden` document This document is generated when the user sets a password, which may not be the case yet for OIDC users In this case fetching `io.cozy.settings.bitwarden` would return an error and it would not be possible to access the application as it is called as an `isInstalled` guard This fix allow to access the installation page if no `io.cozy.settings.bitwarden` exists. Then we excpect the installation page to force the user to set a password which would generated the `io.cozy.settings.bitwarden` document `cozy-keys-lib` has been updated to `3.9.1` to retrieve a fix on `computeMasterKey` mechanism from cozy/cozy-keys-lib#162
Some old Cozy may not have any `io.cozy.settings.bitwarden` document This document is generated when the user sets a password, which may not be the case yet for OIDC users In this case fetching `io.cozy.settings.bitwarden` would return an error and it would not be possible to access the application as it is called as an `isInstalled` guard This fix allow to access the installation page if no `io.cozy.settings.bitwarden` exists. Then we excpect the installation page to force the user to set a password which would generated the `io.cozy.settings.bitwarden` document `cozy-keys-lib` has been updated to `3.9.1` to retrieve a fix on `computeMasterKey` mechanism from cozy/cozy-keys-lib#162
Previous version introduced unnecessary complexity as
kdfIterationsandkdfwere ignored byauthService.makePreloginKey()Also the
iterationshandling did not work correctly as the ternary operator was reversedAs the only value of
authService.makePreloginKey()is to querykdfIterationsandkdfand because we never callcomputeMasterKey()with those values unset, then we callcryptoService.makeKey()directly