Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean cozy-keys-lib usage in other apps #164

Open
Ldoppea opened this issue Sep 9, 2021 · 0 comments
Open

Clean cozy-keys-lib usage in other apps #164

Ldoppea opened this issue Sep 9, 2021 · 0 comments

Comments

@Ldoppea
Copy link
Member

Ldoppea commented Sep 9, 2021

Some methods from cozy-keys-lib are not used anywhere while other apps implement similar methods:

  • WebVaultClient.changePassword() is not used by other apps.
    • cozy-settings implements a similar method that may be replaced by cozy-keys-lib version.
    • cozy-pass-web implements a forceSetVaultPassphrase() method that is prety similar but doesn't handle currentMasterPassword and should be implemented in cozy-keys-lib as a setPassword() method.
  • cozy-pass-web has code to handle unconfirmed organization with no key that should be moved on cozy-keys-lib so cozy-keys-browser can also use it. More info : Feat/hide no key orgs cozy-pass-web#37 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant