-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files data card #1279
Merged
Files data card #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file datacard functionality is behind the harvest.datacards.files flag. This flag activates the file datacard for konnectors that have permission on io.cozy.files and deactivates the drive card that is shown for triggers that have message.folder_to_save. The precise logic on when to show the datacards has not been completely decided yet. It will surely change in the future.
Otherwise, we have a warning "sort on indexed fields" since at the point of the sort, the query definition does not have any indexed field
It will be easy to re-add if we need it
The check on client.plugins would return early if the client did not have the realtime plugin; thus, useEffect was called conditionally. Now the check for plugins is done inside the useEffect.
Crash--
reviewed
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It remains to put all the logic of certifications in the viewer directly since we don't redirect to Drive's viewer ^^.
Nice work
Crash--
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imports data
needs to be set
Next steps:
more obvious
the state is not good
if this code will survive, I plan to add tests when the flag is removed.
Those steps will be done in a future PR.
This future is testable on the following adhoc build: