Refactor/prepare update sharing modal #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Dec 29, 2022
Crash--
reviewed
Dec 29, 2022
zatteo
force-pushed
the
refactor/prepare-update-sharing-modal
branch
from
99e5c1e
to
7ad9fe5
Compare
paultranvan
reviewed
Dec 29, 2022
Ldoppea
reviewed
Dec 30, 2022
zatteo
force-pushed
the
refactor/prepare-update-sharing-modal
branch
from
7ad9fe5
to
b15d69f
Compare
Crash--
approved these changes
Jan 2, 2023
When I added a waitFor from testing-library, I encountered a "MutationObserver is not a constructor" error because jsdom version was too old.
zatteo
force-pushed
the
refactor/prepare-update-sharing-modal
branch
from
b15d69f
to
8d04ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating class components to functional components and updating query method.