feat: Download file on mobile viewer on press #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to download file on mobile viewer on press (so when we put the finger on the screen) and not on tap (so when we put the finger on the screen and we release it). I added a throttle to avoid download multiple time the same file because we can no use anymore 'tapCount' with press which was used to avoid download 3 times the file if we tapped 3 times. I also moved to useMemo instead of useCallback to support throttle (see facebook/react#19240).
Merkur39
approved these changes
Oct 30, 2024
Comment on lines
+36
to
+53
| const handleOnClick = useMemo( | ||
| () => | ||
| throttle( | ||
| async file => { | ||
| try { | ||
| await downloadFile({ client, file, webviewIntent }) | ||
| } catch (error) { | ||
| showAlert({ | ||
| message: t('Viewer.error.generic'), | ||
| severity: 'error', | ||
| variant: 'filled', | ||
| icon: false | ||
| }) | ||
| } | ||
| }, | ||
| 1000, | ||
| { trailing: false } | ||
| ), |
There was a problem hiding this comment.
info: This approach is also functional
https://github.com/cozy/cozy-contacts/blob/26b30f5160ff6e7543e7f2e134bd1893f701c99b/src/components/Modals/ContactInfoTitle.jsx#L62-L75
There was a problem hiding this comment.
Interesting thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to download file on mobile viewer on press (so when we put the finger on the screen) and not on tap (so when we put the finger on the screen and we release it).
I added a throttle to avoid download multiple time the same file because we can no use anymore 'tapCount' with press which was used to avoid download 3 times the file if we tapped 3 times.
I also moved to useMemo instead of useCallback to support throttle (see facebook/react#19240).