feat(sharing): Improve Share by links #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
force-pushed
the
feat/vo-1244
branch
3 times, most recently
from
f3d8620 to
b83e5f0
Compare
Merkur39
force-pushed
the
feat/vo-1244
branch
from
e0b26a4 to
224e482
Compare
Merkur39
requested review from
JF-Cozy,
Ldoppea,
zatteo and
doubleface
as code owners
zatteo
reviewed
Jan 21, 2025
packages/cozy-sharing/src/components/ShareRestrictionModal/ShareRestrictionModal.jsx
Show resolved
Hide resolved
Merkur39
force-pushed
the
feat/vo-1244
branch
from
224e482 to
f68c3a4
Compare
zatteo
approved these changes
Jan 22, 2025
Merkur39
force-pushed
the
feat/vo-1244
branch
from
f68c3a4 to
1827921
Compare
BREAKING CHANGE: You must have `cozy-client >= 53.0.0`
Cozy-client has been updated, allowing us to make a few optimizations here. The `forwardFile` function has no place here, as it is only used on mobile (which is another component).
As we can't display the previously saved password, we'd like to display a specific placeholder that improves the UX. We'll also make sure that the password value is `“”` and not `undefined` when we deactivate it. This makes it clear to the stack that we want to delete the password and not keep it unchanged.
The user can find out as soon as he opens the sharing modal whether his link sharing is secure, and see its expiry date.
Now that new attributes such as `expiresAt` and `password` exist, this has highlighted a bug due to the fact that the `updateSharingLink` parameter was wrong.
Changed validation conditions when creating a share link.
Merkur39
force-pushed
the
feat/vo-1244
branch
from
1827921 to
50964d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and improves the new share link UX.