Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sharing): Improve Share by links #2694

Merged
merged 7 commits into from
Jan 22, 2025
Merged

feat(sharing): Improve Share by links #2694

merged 7 commits into from
Jan 22, 2025

Conversation

Merkur39
Copy link
Contributor

@Merkur39 Merkur39 commented Jan 10, 2025

@Merkur39 Merkur39 force-pushed the feat/vo-1244 branch 3 times, most recently from f3d8620 to b83e5f0 Compare January 17, 2025 14:58
@Merkur39 Merkur39 changed the title feat(sharing): Wip feat(sharing): Improve Share by links Jan 21, 2025
@Merkur39 Merkur39 marked this pull request as ready for review January 21, 2025 12:39
BREAKING CHANGE: You must have `cozy-client >= 53.0.0`
Cozy-client has been updated, allowing us to make
a few optimizations here.

The `forwardFile` function has no place here,
as it is only used on mobile (which is another component).
As we can't display the previously saved password,
we'd like to display a specific placeholder
that improves the UX.

We'll also make sure that the password value is `“”`
and not `undefined` when we deactivate it.
This makes it clear to the stack that we want to delete
the password and not keep it unchanged.
The user can find out as soon as he opens the sharing
modal whether his link sharing is secure,
and see its expiry date.
Now that new attributes such as `expiresAt` and
`password` exist, this has highlighted a bug due to the
fact that the `updateSharingLink` parameter was wrong.
Changed validation conditions when creating a share link.
@Merkur39 Merkur39 merged commit 00fb730 into master Jan 22, 2025
2 checks passed
@Merkur39 Merkur39 deleted the feat/vo-1244 branch January 22, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants