refactor: Clean unused mobile target #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nop, it's part of the create-cozy-app template (https://github.com/cozy/create-cozy-app/tree/master/packages/cozy-scripts/template/app) |
BundleMonUnchanged files (3)
No change in files bundle size Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
force-pushed
the
refactor/remove-cordova-related-code
branch
from
d91807d to
aef69a6
Compare
Right! I fixed it in create-cozy-app repo too (cozy/create-cozy-app#1503) |
cballevre
reviewed
Jun 3, 2024
package.json
Outdated
| @@ -5,7 +5,6 @@ | |||
| "analyze": "COZY_SCRIPTS_ANALYZER=true yarn build", | |||
| "build:browser:dev": "cs build --browser --development", | |||
There was a problem hiding this comment.
nit: I think specify browser is no longer useful now. We could keep just watch, build like in Drive
cballevre
approved these changes
Jun 4, 2024
zatteo
force-pushed
the
refactor/remove-cordova-related-code
branch
from
ce7e29f to
d60bd10
Compare
Mobile target is added automatically by create-cozy-app but was never used on cozy-notes.
zatteo
force-pushed
the
refactor/remove-cordova-related-code
branch
from
d60bd10 to
11c9c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something started but never finished ? 🤷♂️