This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
Allow to parse response after a file upload + gzip test #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular for https://nodesecurity.io/advisories/130
It doesn't parse response by default to not change the previous behaviour.
nono
approved these changes
Mar 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made a fix for the #50 issue. It simply allows to parse response when a file is uploaded.
I added a test for gzipped response parsing (#58). Everything seems to work fine. So, I didn't commit any fix for this.
Regards,
Frank Rousseau