enhancements for offline use #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additional html rendering with alternative css - just testing modified: nvpy/nvpy-example.cfg modified: nvpy/nvpy.py modified: nvpy/view.py
…e extension txt or md is set in config file instead
yuuki0xff
requested changes
Dec 18, 2022
| def observer_view_markdown(self, view, evt_type, evt): | ||
| fn = self.helper_markdown_to_html() | ||
| # turn filename into URI (mac wants this) | ||
| fn_uri = 'file://' + os.path.abspath(fn) | ||
| webbrowser.open(fn_uri) | ||
|
|
||
| def observer_view_markdown_raw(self, view, evt_type, evt): | ||
| fn = self.helper_render_markdown_raw() | ||
| subprocess.Popen([os.path.abspath(fn)],shell=True) |
There was a problem hiding this comment.
- If no note is selected or the notes_as_txt feature is disabled,
abspath()raisesTypeErrorbecausefnis None. - On UNIX-like platforms,
Popen()should fail because*.txtor*.mkdnfiles are generally not executable.
| if note_markdown(note): | ||
| fn += '.mkdn' | ||
| else: | ||
| fn += '.txt' |
There was a problem hiding this comment.
Degraded. systemtags are updated by Simplenote. It is an array that contains "pinned" or "markdown". nvPY changes the file extension based on it.
The internal data model of nvpy takes a lot of work to grasp. I plan to improve it in v2.4.0 or later.
| @@ -300,6 +268,46 @@ def __init__(self, config): | |||
|
|
|||
| self.config = config | |||
|
|
|||
| # simplenote only imported if simplenote_sync activated in config-file | |||
There was a problem hiding this comment.
Quoting from the README.rst:
nvpy is a simplenote-syncing note-taking tool
I developed and tested assuming that the nvPY user uses simplenote synchronization feature. I don't want to complicate source code just to decouple simplenote library dependencies.
|
@jkall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions: