Add Sqlite as a backend for notes storage #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a class which relies on an sqlite full text search table rather than on json files for notes storage, and a configuration option to switch between the two. The sqlite backend greatly improves startup time and search speed, especially in case insensitive mode. It also allows for boolean searches. These features are still missing from the new backend: - Simplenote sync - Writing notes to file - Sorting and pinned notes - Regex-style search
|
This is really awesome, and something I really think we should do. The most important thing we need to get working, is the simplenote sync. You've done a sterling job writing a new NotesDB for the sqlite backend. I think if we could also factor out the syncer, then we would have seamless support for the different storage backends. I hope I get some time to look at this in the coming weekes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a class which relies on an sqlite full text search table rather
than on json files for notes storage, and a configuration option to
switch between the two. The sqlite backend greatly improves startup
time and search speed, especially in case insensitive mode. It also
allows for boolean searches.
These features are still missing from the new backend: