Rebase to latest api #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alkurbatov
commented
Oct 8, 2023
alkurbatov
commented
- Fetch cpp-sc2 using CMake instead of manual manipulations with submodule.
- Make changes necessary to compile with new cpp-sc2.
- Refactor CMake build routine.
- Update build instructions.
alkurbatov
force-pushed
the
rebase_to_latest_api
branch
from
8aa1884
to
674d5f9
Compare
- Fetch cpp-sc2 using CMake instead of manual manipulations with submodule. - Make changes necessary to compile with new cpp-sc2. - Refactor CMake build routine. - Update build instructions. Signed-off-by: Alexander Kurbatov <[email protected]>
To avoid warnings in CI. Signed-off-by: Alexander Kurbatov <[email protected]>
Signed-off-by: Alexander Kurbatov <[email protected]>
For clarity and simplicity. Signed-off-by: Alexander Kurbatov <[email protected]>
alkurbatov
force-pushed
the
rebase_to_latest_api
branch
from
674d5f9
to
d9c64ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.