-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala Native 0.5.x #508
Scala Native 0.5.x #508
Conversation
# Conflicts: # .github/workflows/ci.yml # build.sbt # project/plugins.sbt
8aeb129
to
248ccca
Compare
Any idea why Scala Native tests are always failing with this? @cquiroz @WojciechMazur
I'm getting a bit desperate here... |
Can't say much, I haven't use native before and since jvm and js run I'd think it is more on the native side. |
Looks like an issue on SN side, it's basically a segmentation fault. I'll try to minimize and fix it asap |
Cats had the same error typelevel/cats#4585 (review). I am not sure what they did to make it go away |
A quick update on the segmentation faults: |
The regression introduced in 0.5.x was fixed, we'd make a release soon - there is 1 more issue reported by the os-lib we'd like to ship as well. scala-native/scala-native#3939 |
0.5.3 with the fix has been released |
@@ -160,6 +162,7 @@ lazy val core = crossProject(JVMPlatform, JSPlatform, NativePlatform) | |||
) | |||
) | |||
.nativeSettings( | |||
scalacOptions += "-P:scalanative:genStaticForwardersForNonTopLevelObjects", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be different for Scala 3?
(CrossVersion.partialVersion(scalaVersion.value) match {
case Some((2, _)) => "-P:scalanative:genStaticForwardersForNonTopLevelObjects"
case _ => "-scalanative-genStaticForwardersForNonTopLevelObjects"
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that doesn't work. Has to be like it is currently in the PR. The tests being green are the proof :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'-P' stands for prefix for compiler settings. In case of Scala.js the compiler plugin setting in Scala 2 was elevated to standalone setting in Scala 3 after Scala.js backend become a part of compiler.
Scala Native is not going to become part of compiler at least until 1.0
@cquiroz we can merge 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for getting this through
Thanks for merging! Could you please make a release @cquiroz ? 🙏 |
closes #504
closes #513
closes #493
blocked on
blocked on