Delay queue push #18
Merged
Delay queue push #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
commented
Nov 28, 2023
| * | ||
| * Priority is not supported by SQS | ||
| */ | ||
| return parent::pushMessage($message, (string) $ttr, $delay, null); |
There was a problem hiding this comment.
See any trouble with passing null for priority? SQS doesn't support it, so we have to.
There was a problem hiding this comment.
That's fine. But also a good reason to move away from SQS down the road.
| * the job will exist and be indefinitely pending. | ||
| */ | ||
| Craft::$app->onAfterRequest(function() use ($message, $ttr, $delay) { | ||
|
|
There was a problem hiding this comment.
@brandonkelly are you sure we shouldn't do a last check to ensure we're not in a transaction?
There was a problem hiding this comment.
Anything doing stuff that requires a transaction at this point is doing it wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missed jobs by delaying queue push until
onAfterRequest.