added entrify event #13391
Open
added entrify event #13391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
requested changes
Jul 14, 2023
There was a problem hiding this comment.
I think it would be better to have separate EVENT_ENTRIFY_CATEGORIES, EVENT_ENTRIFY_TAGS, and EVENT_ENTRIFY_GLOBAL_SET events, each with their own dedicated event classes, with typed properties for all the associated data (CategoryGroup $categoryGroup, Section $section, EntryType $entryType), etc. And then there’s no need for $elementType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
EntrifyEvent, fired at the end of each entrify command (entrify/categories,entrify/global-set,entrify/tags).(After this is released, a Feed Me PR (work in progress) can be released too.)
Related issues
#1340