Allow env config for attributes #13666
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detects if you pass
\craft\helpers\App::envConfiga Model, and if so, uses the the model's attributes instead of just getting public properties.This allows config overrides to work if you have an attribute with a getter/setter.
Another option could be to just allow you to pass an array of properties to override, so when you called
\craft\helpers\App::envConfig, you could just pass if your model's attributes.One potential issue here might be if you have a read-only attribute (no setter), and you try to set the corresponding env for it, it will throw.