Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of SVG sanitizer #14620

Open
wants to merge 2 commits into
base: 4.14
Choose a base branch
from

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Mar 18, 2024

Description

Allows configuration of the SVG sanitizer by accepting bool|callable.
A more flexible alternative to #14492, which exposes a new dedicated for sanitizeSvgRemoteRefs.

Related issues

#14492

@timkelty timkelty force-pushed the feature/svg-sanitize-config branch from caffa5f to addd648 Compare March 18, 2024 20:53
@timkelty timkelty force-pushed the feature/svg-sanitize-config branch from addd648 to 2dbce3e Compare March 18, 2024 20:55
@timkelty timkelty requested a review from brandonkelly March 18, 2024 20:56
@brandonkelly brandonkelly changed the base branch from develop to 4.9 March 19, 2024 06:49
@cgivord
Copy link

cgivord commented Apr 25, 2024

I don't think this is necessary to have a more flexible way than #14492 because the sanitizer library does not offer much options.
Also, IMHO, adding code to the config file is not recommended long term.

@brandonkelly brandonkelly changed the base branch from 4.9 to 4.10 April 30, 2024 15:05
@brandonkelly brandonkelly changed the base branch from 4.10 to 4.11 June 7, 2024 21:26
@brandonkelly brandonkelly changed the base branch from 4.11 to 4.12 August 7, 2024 13:42
@brandonkelly brandonkelly changed the base branch from 4.12 to 4.13 September 3, 2024 17:45
@brandonkelly brandonkelly changed the base branch from 4.13 to 4.14 November 15, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants