Feature/cms 660 show read-only settings when allowAdminChanges is disabled

src/base/Plugin.php

@@ -302,6 +302,14 @@ public function afterSaveSettings(): void
         }
     }
 
+    /**
+     * @inheritdoc
+     */
+    public function canViewReadOnlySettings(): bool
+    {
+        return false;
+    }
+
     /**
      * Instantiates and returns the plugin’s installation migration, if it has one.
      *

src/base/PluginInterface.php

@@ -185,4 +185,12 @@ public function beforeSaveSettings(): bool;
      * @since 3.0.16
      */
     public function afterSaveSettings(): void;
+
+    /**
+     * Returns whether plugin is prepared to view its settings when `allowAdminChanges` is disabled.
+     *
+     * @return bool
+     * @since 5.6.0
+     */
+    public function canViewReadOnlySettings(): bool;
 }

src/controllers/CategoriesController.php

@@ -54,12 +54,13 @@ class CategoriesController extends Controller
      */
     public function actionGroupIndex(): Response
     {
-        $this->requireAdmin();
+        $this->requireAdmin(false);
 
         $groups = Craft::$app->getCategories()->getAllGroups();
 
         return $this->renderTemplate('settings/categories/index.twig', [
             'categoryGroups' => $groups,
+            'readOnly' => !Craft::$app->getConfig()->getGeneral()->allowAdminChanges,
         ]);
     }
 
@@ -73,7 +74,13 @@ public function actionGroupIndex(): Response
      */
     public function actionEditCategoryGroup(?int $groupId = null, ?CategoryGroup $categoryGroup = null): Response
     {
-        $this->requireAdmin();
+        $this->requireAdmin(false);
+
+        $readOnly = !Craft::$app->getConfig()->getGeneral()->allowAdminChanges;
+
+        if ($groupId === null && $readOnly) {
+            throw new ForbiddenHttpException('Administrative changes are disallowed in this environment.');
+        }
 
         $variables = [];
 
@@ -112,6 +119,7 @@ public function actionEditCategoryGroup(?int $groupId = null, ?CategoryGroup $ca
 
         $variables['groupId'] = $groupId;
         $variables['categoryGroup'] = $categoryGroup;
+        $variables['readOnly'] = $readOnly;
 
         return $this->renderTemplate('settings/categories/_edit.twig', $variables);
     }

src/controllers/ElementsController.php

@@ -1184,10 +1184,10 @@ private function _revisionNotice($elementType): string
     {
         return
             Html::beginTag('div', [
-                'class' => 'revision-notice',
+                'class' => 'content-notice',
             ]) .
             Html::tag('div', '', [
-                'class' => ['revision-icon'],
+                'class' => ['content-notice-icon'],
                 'aria' => ['hidden' => 'true'],
                 'data' => ['icon' => 'lightbulb'],
             ]) .

src/controllers/EntryTypesController.php

@@ -20,6 +20,7 @@
 use craft\models\Section;
 use craft\web\Controller;
 use yii\web\BadRequestHttpException;
+use yii\web\ForbiddenHttpException;
 use yii\web\NotFoundHttpException;
 use yii\web\Response;
 
@@ -33,13 +34,26 @@
  */
 class EntryTypesController extends Controller
 {
+    private bool $readOnly;
+
     /**
      * @inheritdoc
      */
     public function beforeAction($action): bool
     {
-        // All section actions require an admin
-        $this->requireAdmin();
+        // All actions require an admin account (but not allowAdminChanges)
+        $this->requireAdmin(false);
+
+        $viewActions = ['edit', 'table-data'];
+        if (in_array($action->id, $viewActions)) {
+            // Some actions require admin but not allowAdminChanges
+            $this->requireAdmin(false);
+        } else {
+            // All other actions require an admin & allowAdminChanges
+            $this->requireAdmin();
+        }
+
+        $this->readOnly = !Craft::$app->getConfig()->getGeneral()->allowAdminChanges;
 
         return parent::beforeAction($action);
     }
@@ -54,6 +68,10 @@ public function beforeAction($action): bool
      */
     public function actionEdit(?int $entryTypeId = null, ?EntryType $entryType = null): Response
     {
+        if ($entryTypeId === null && $this->readOnly) {
+            throw new ForbiddenHttpException('Administrative changes are disallowed in this environment.');
+        }
+
         if ($entryTypeId !== null) {
             if ($entryType === null) {
                 $entryType = Craft::$app->getEntries()->getEntryTypeById($entryTypeId);
@@ -91,26 +109,36 @@ public function actionEdit(?int $entryTypeId = null, ?EntryType $entryType = nul
             ->title($title)
             ->addCrumb(Craft::t('app', 'Settings'), 'settings')
             ->addCrumb(Craft::t('app', 'Entry Types'), 'settings/entry-types')
-            ->action('entry-types/save')
-            ->redirectUrl('settings/entry-types')
-            ->addAltAction(Craft::t('app', 'Save and continue editing'), [
-                'redirect' => 'settings/entry-types/{id}',
-                'shortcut' => true,
-                'retainScroll' => true,
-            ])
             ->contentTemplate('settings/entry-types/_edit.twig', [
                 'entryTypeId' => $entryTypeId,
                 'entryType' => $entryType,
                 'typeName' => Entry::displayName(),
                 'lowerTypeName' => Entry::lowerDisplayName(),
+                'readOnly' => $this->readOnly,
             ]);
 
-        if ($entryType->id) {
+        if (!$this->readOnly) {
             $response
-                ->addAltAction(Craft::t('app', 'Delete'), [
+                ->action('entry-types/save')
+                ->redirectUrl('settings/entry-types')
+                ->addAltAction(Craft::t('app', 'Save and continue editing'), [
+                    'redirect' => 'settings/entry-types/{id}',
+                    'shortcut' => true,
+                    'retainScroll' => true,
+                ]);
+        } else {
+            $response->noticeHtml(Cp::allowAdminChangesReadOnlyNotice());
+        }
+
+        if ($entryType->id) {
+            if (!$this->readOnly) {
+                $response->addAltAction(Craft::t('app', 'Delete'), [
                     'action' => 'entry-types/delete',
                     'destructive' => true,
-                ])
+                ]);
+            }
+
+            $response
                 ->metaSidebarHtml(Cp::metadataHtml([
                     Craft::t('app', 'ID') => $entryType->id,
                     Craft::t('app', 'Used by') => function() use ($entryType) {