Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update customer condition rule to use element selector #3293

Merged
merged 9 commits into from
Oct 17, 2023

Conversation

nfourtythree
Copy link
Contributor

Description

Currently. the customer condition rule uses a multi-select for the purpose of selecting the users for the rule. There is an issue with this when there are a large number of users.

This PR updates the rule to make use of the element selector modal instead.

Related issues

#3291

@nfourtythree nfourtythree self-assigned this Oct 10, 2023
@what-the-diff
Copy link

what-the-diff bot commented Oct 10, 2023

PR Summary

  • Update to 'CustomerConditionRule' class
    The class that helps manage customer conditions has been improved. We've incorporated additional functionalities from other units of our code (Craft and Yii) which enhances the overall operations.

  • New feature: inputHtml()
    A new function has been added to the class which lets the system to fetch user data and return it in the form of an HTML input field. This enhancement should improve the manner in which we handle user information.

  • Deprecation of 'options()' method
    The existing 'options' function in this class will not be maintained in the future as it's becoming outdated (from version 4.3.1). This information is important to those who are using or planning to use this function.

  • Repository Querying Improvement in 'modifyQuery()'
    Changes have been made in the 'modifyQuery' function to improve how we query our database. This update now allows for more complex queries, enhancing our ability to retrieve information efficiently, specifically when using a combination of 'not' and 'in' operators.

@nfourtythree nfourtythree marked this pull request as ready for review October 13, 2023 15:33
@nfourtythree nfourtythree requested a review from a team as a code owner October 13, 2023 15:33
@lukeholder lukeholder merged commit 451de16 into develop Oct 17, 2023
@lukeholder lukeholder deleted the bugfix/customer-condition-rule-element-select branch October 17, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants