Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty column headings in feed cause incorrect pagination url dropdown value. #1375

Closed
mikeymeister opened this issue Oct 30, 2023 · 1 comment
Assignees
Labels

Comments

@mikeymeister
Copy link

mikeymeister commented Oct 30, 2023

Description

We have come across a case where the google sheet used for the feed has a column of data with no heading in the first row. When trying to save the pagination url, the select field has multiple options with value="".
Screenshot 2023-10-30 at 20 31 16
This causes the dropdown to show the latest empty value option as the pagination url. I fully accept that the data is poorly formed for a feed and that this is in edge case territory.
Perhaps "No Pagination URL" should be an option with a value that specifies there is no pagination url rather than the absence of a value eg <option value="no-pagination">No Pagination URL</option>? Or exclude options from the dropdown that don't have a key? There could even be a lightswitch for pagination url that when enabled, displays valid options for a pagination url from the feed.

Steps to reproduce

  1. Set up a feed from a google sheet where at least one of the table columns has no heading
  2. Try to save the feed with no pagination url set.

Additional info

  • Craft version: 4.4.15
  • PHP version: 8.1
  • Database driver & version: MariaDB 10.11.5
  • Plugins & versions: Feed Me - 5.2.0
@angrybrad
Copy link
Member

Resolved in #1385 and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants